Message ID | 01b4b3af-6b3b-281e-31b6-8d852e76bc52@suse.com |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot,GIT,PULL] Raspberry Pi updates for v2020.01 | expand |
On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: > Hi Tom, > > Please have a look at the below patches. > Travis-ci can be found here: > https://travis-ci.org/mbgg/u-boot/builds/614078145 > > Apart from this patches, I planning to send another pull request once the single > binary series is ready to be merged. But for now, we should take this patches as > it fixes some FAT write errors and the boot banner issue for RPi3 you detected. > > Regards, > Matthias > NAK, this seems to break FAT in some cases: https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 (and similar in Azure and Travis).
Hi Tom, On 20/11/2019 02:57, Tom Rini wrote: > On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: > >> Hi Tom, >> >> Please have a look at the below patches. >> Travis-ci can be found here: >> https://travis-ci.org/mbgg/u-boot/builds/614078145 >> >> Apart from this patches, I planning to send another pull request once the single >> binary series is ready to be merged. But for now, we should take this patches as >> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >> >> Regards, >> Matthias >> > > NAK, this seems to break FAT in some cases: > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 > (and similar in Azure and Travis). > It seems that it does not break in travis, but it also seems that the CI diverged between travis and gitlab: https://travis-ci.org/mbgg/u-boot/jobs/614078209 https://travis-ci.org/mbgg/u-boot/jobs/614078210 @Tom are you aware of that? @Marek can you have a look into the FAT errors please? Regards, Matthias
On Wed, Nov 20, 2019 at 10:10:00AM +0100, Matthias Brugger wrote: > Hi Tom, > > On 20/11/2019 02:57, Tom Rini wrote: > > On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: > > > >> Hi Tom, > >> > >> Please have a look at the below patches. > >> Travis-ci can be found here: > >> https://travis-ci.org/mbgg/u-boot/builds/614078145 > >> > >> Apart from this patches, I planning to send another pull request once the single > >> binary series is ready to be merged. But for now, we should take this patches as > >> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. > >> > >> Regards, > >> Matthias > >> > > > > NAK, this seems to break FAT in some cases: > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 > > (and similar in Azure and Travis). > > > > It seems that it does not break in travis, but it also seems that the CI > diverged between travis and gitlab: > https://travis-ci.org/mbgg/u-boot/jobs/614078209 > https://travis-ci.org/mbgg/u-boot/jobs/614078210 > > @Tom are you aware of that? Ah yes, oops. Travis does not, and I cannot figure out why, run the filesystem tests. Azure and GitLab both do. Setup is the same in both cases, I thought. Generally one should be able to run them locally as well.
Hi Matthias, On 20.11.2019 10:10, Matthias Brugger wrote: > Hi Tom, > > On 20/11/2019 02:57, Tom Rini wrote: >> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >> >>> Hi Tom, >>> >>> Please have a look at the below patches. >>> Travis-ci can be found here: >>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>> >>> Apart from this patches, I planning to send another pull request once the single >>> binary series is ready to be merged. But for now, we should take this patches as >>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>> >>> Regards, >>> Matthias >>> >> NAK, this seems to break FAT in some cases: >> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >> (and similar in Azure and Travis). >> > It seems that it does not break in travis, but it also seems that the CI > diverged between travis and gitlab: > https://travis-ci.org/mbgg/u-boot/jobs/614078209 > https://travis-ci.org/mbgg/u-boot/jobs/614078210 > > @Tom are you aware of that? > > @Marek can you have a look into the FAT errors please? Yes, I will take care of them. It looks that my fixes revealed bugs in other parts of fat code... Best regards
On 22/11/2019 14:40, Marek Szyprowski wrote: > Hi Matthias, > > On 20.11.2019 10:10, Matthias Brugger wrote: >> Hi Tom, >> >> On 20/11/2019 02:57, Tom Rini wrote: >>> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >>> >>>> Hi Tom, >>>> >>>> Please have a look at the below patches. >>>> Travis-ci can be found here: >>>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>>> >>>> Apart from this patches, I planning to send another pull request once the single >>>> binary series is ready to be merged. But for now, we should take this patches as >>>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>>> >>>> Regards, >>>> Matthias >>>> >>> NAK, this seems to break FAT in some cases: >>> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >>> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >>> (and similar in Azure and Travis). >>> >> It seems that it does not break in travis, but it also seems that the CI >> diverged between travis and gitlab: >> https://travis-ci.org/mbgg/u-boot/jobs/614078209 >> https://travis-ci.org/mbgg/u-boot/jobs/614078210 >> >> @Tom are you aware of that? >> >> @Marek can you have a look into the FAT errors please? > > Yes, I will take care of them. It looks that my fixes revealed bugs in > other parts of fat code... > Thanks. I'll postpone your DFU series for now, as they are rahter useless without a working FAT partition. I can merge it when all the FAT related problems are fixed. Sounds good? Regards, Matthias
Hi Matthias, On 24.11.2019 10:39, Matthias Brugger wrote: > On 22/11/2019 14:40, Marek Szyprowski wrote: >> On 20.11.2019 10:10, Matthias Brugger wrote: >>> On 20/11/2019 02:57, Tom Rini wrote: >>>> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >>>>> Please have a look at the below patches. >>>>> Travis-ci can be found here: >>>>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>>>> >>>>> Apart from this patches, I planning to send another pull request once the single >>>>> binary series is ready to be merged. But for now, we should take this patches as >>>>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>>>> >>>>> Regards, >>>>> Matthias >>>>> >>>> NAK, this seems to break FAT in some cases: >>>> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >>>> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >>>> (and similar in Azure and Travis). >>>> >>> It seems that it does not break in travis, but it also seems that the CI >>> diverged between travis and gitlab: >>> https://travis-ci.org/mbgg/u-boot/jobs/614078209 >>> https://travis-ci.org/mbgg/u-boot/jobs/614078210 >>> >>> @Tom are you aware of that? >>> >>> @Marek can you have a look into the FAT errors please? >> Yes, I will take care of them. It looks that my fixes revealed bugs in >> other parts of fat code... >> > Thanks. I'll postpone your DFU series for now, as they are rahter useless > without a working FAT partition. I can merge it when all the FAT related > problems are fixed. Sounds good? I've managed to identify the FAT/sandbox issue and fixed it. I've sent a v3 of complete RPi4 DFU patchset a few minutes ago: https://patchwork.ozlabs.org/cover/1200793/ Best regards
Hi Marek, On 26/11/2019 09:25, Marek Szyprowski wrote: > Hi Matthias, > > On 24.11.2019 10:39, Matthias Brugger wrote: >> On 22/11/2019 14:40, Marek Szyprowski wrote: >>> On 20.11.2019 10:10, Matthias Brugger wrote: >>>> On 20/11/2019 02:57, Tom Rini wrote: >>>>> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >>>>>> Please have a look at the below patches. >>>>>> Travis-ci can be found here: >>>>>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>>>>> >>>>>> Apart from this patches, I planning to send another pull request once the single >>>>>> binary series is ready to be merged. But for now, we should take this patches as >>>>>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>>>>> >>>>>> Regards, >>>>>> Matthias >>>>>> >>>>> NAK, this seems to break FAT in some cases: >>>>> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >>>>> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >>>>> (and similar in Azure and Travis). >>>>> >>>> It seems that it does not break in travis, but it also seems that the CI >>>> diverged between travis and gitlab: >>>> https://travis-ci.org/mbgg/u-boot/jobs/614078209 >>>> https://travis-ci.org/mbgg/u-boot/jobs/614078210 >>>> >>>> @Tom are you aware of that? >>>> >>>> @Marek can you have a look into the FAT errors please? >>> Yes, I will take care of them. It looks that my fixes revealed bugs in >>> other parts of fat code... >>> >> Thanks. I'll postpone your DFU series for now, as they are rahter useless >> without a working FAT partition. I can merge it when all the FAT related >> problems are fixed. Sounds good? > > I've managed to identify the FAT/sandbox issue and fixed it. I've sent a > v3 of complete RPi4 DFU patchset a few minutes ago: > https://patchwork.ozlabs.org/cover/1200793/ > Thanks for the quick fix. I'll wait to see if someone with more knowledge can review the patch and then will send the whole series for inclusion. Regards, Matthias