diff mbox series

[U-Boot,RFC,04/29] drivers: pci-uclass: fix incorrect argument in map_sysmem

Message ID 20191029210821.1954-5-suneelglinux@gmail.com
State RFC
Delegated to: Tom Rini
Headers show
Series arm: Introduce Marvell/Cavium OcteonTX | expand

Commit Message

Suneel Garapati Oct. 29, 2019, 9:07 p.m. UTC
From: Suneel Garapati <sgarapati@marvell.com>

Minor spelling correction.

Signed-off-by: Suneel Garapati <sgarapati@marvell.com>
---
 drivers/pci/pci-uclass.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Nov. 20, 2019, 3 a.m. UTC | #1
Hi Suneel,

On Tue, 29 Oct 2019 at 14:08, Suneel Garapati <suneelglinux@gmail.com> wrote:
>
> From: Suneel Garapati <sgarapati@marvell.com>
>
> Minor spelling correction.

Also mention your bug, and ideally add a Fixes: tag.

>
> Signed-off-by: Suneel Garapati <sgarapati@marvell.com>
> ---
>  drivers/pci/pci-uclass.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
> index 896cb6b23a..848ac5a65e 100644
> --- a/drivers/pci/pci-uclass.c
> +++ b/drivers/pci/pci-uclass.c
> @@ -1373,7 +1373,7 @@ static void *dm_pci_map_ea_bar(struct udevice *dev, int bar, int flags,
>                 }
>
>                 /* size ignored for now */
> -               return map_physmem(addr, flags, 0);
> +               return map_physmem(addr, 0, flags);
>         }
>
>         return 0;
> @@ -1399,7 +1399,7 @@ void *dm_pci_map_bar(struct udevice *dev, int bar, int flags)
>
>         /*
>          * Pass "0" as the length argument to pci_bus_to_virt.  The arg
> -        * isn't actualy used on any platform because u-boot assumes a static
> +        * isn't actually used on any platform because u-boot assumes a static
>          * linear mapping.  In the future, this could read the BAR size
>          * and pass that as the size if needed.
>          */
> --
> 2.23.0
>

Regards,
Simon
diff mbox series

Patch

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 896cb6b23a..848ac5a65e 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -1373,7 +1373,7 @@  static void *dm_pci_map_ea_bar(struct udevice *dev, int bar, int flags,
 		}
 
 		/* size ignored for now */
-		return map_physmem(addr, flags, 0);
+		return map_physmem(addr, 0, flags);
 	}
 
 	return 0;
@@ -1399,7 +1399,7 @@  void *dm_pci_map_bar(struct udevice *dev, int bar, int flags)
 
 	/*
 	 * Pass "0" as the length argument to pci_bus_to_virt.  The arg
-	 * isn't actualy used on any platform because u-boot assumes a static
+	 * isn't actually used on any platform because u-boot assumes a static
 	 * linear mapping.  In the future, this could read the BAR size
 	 * and pass that as the size if needed.
 	 */