Message ID | CACPK8Xe8XiJ+oEp3_AXO5Mox-mXWVrOJKQLJMKJxg1WdYCTzMw@mail.gmail.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] ARM: aspeed: devicetree changes for 5.5 | expand |
Hi, On Thu, Nov 07, 2019 at 11:18:10AM +0000, Joel Stanley wrote: > Hello ARM maintainers, > > Here's the ASPEED dts tree for 5.5. > > The following changes since commit 3eca037f2dfce07a31da0a837ac35d6d846614b0: > > ARM: dts: aspeed-g6: Add timer description (2019-11-07 21:23:56 +1030) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git \ > tags/aspeed-5.5-devicetree This is a weird format. Mind changing your script to not put the '\' at EOL? It's messing up the parsing scripts, and git doesn't use it. > for you to fetch changes up to 3eca037f2dfce07a31da0a837ac35d6d846614b0: > > ARM: dts: aspeed-g6: Add timer description (2019-11-07 21:23:56 +1030) > > ---------------------------------------------------------------- > ASPEED device tree updates for 5.5 > > - Lots of work on the AST2600 boards as bringup continues. There's the > eval board, and two IBM boards called Tacoma and Rainier > > - A new flash layout for OpenBMC systems with larger flashes > > - Better support for the MAC clocking when talking to a NCSI device, > making Linux less reliant on u-boot having done the correct thing > > - LED fixes for vesin and fp5280g2 > > - SGPIO support > > - Facebook network BMC cleanup with the common hardware moved to a > shared dtsi > > ---------------------------------------------------------------- ... also, there's no shortlog and no diffstat on the pull request. We usually want to see those. That being said, I merged this branch. Thanks! -Olof
Hey Olof, On Fri, 8 Nov 2019 at 18:32, Olof Johansson <olof@lixom.net> wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git \ > > tags/aspeed-5.5-devicetree > > This is a weird format. Mind changing your script to not put the '\' at EOL? > It's messing up the parsing scripts, and git doesn't use it. I think I added that at your request. I'm happy to do whatever works for you. > > ---------------------------------------------------------------- > > ... also, there's no shortlog and no diffstat on the pull request. We usually > want to see those. In the past git request-pull created those. It seems to have stopped, as I got similar feedback on other pull requests. I guess we need to add that manually now. Cheers, Joel
On Tue, Nov 12, 2019 at 4:40 PM Joel Stanley <joel@jms.id.au> wrote: > > Hey Olof, > > On Fri, 8 Nov 2019 at 18:32, Olof Johansson <olof@lixom.net> wrote: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git \ > > > tags/aspeed-5.5-devicetree > > > > This is a weird format. Mind changing your script to not put the '\' at EOL? > > It's messing up the parsing scripts, and git doesn't use it. > > I think I added that at your request. I'm happy to do whatever works for you. Hah, quite possible -- we used to cut and paste to a terminal so it was useful then. Anyway, I revised my regex here. > > > ---------------------------------------------------------------- > > > > ... also, there's no shortlog and no diffstat on the pull request. We usually > > want to see those. > > In the past git request-pull created those. It seems to have stopped, > as I got similar feedback on other pull requests. > > I guess we need to add that manually now. Yeah, I just saw one more pull request that looked like this. Surprising. -Olof