diff mbox series

net: ethernet: octeon_mgmt: Account for second possible VLAN header

Message ID 20191106153125.118789-1-alexander.sverdlin@nokia.com
State Changes Requested
Delegated to: David Miller
Headers show
Series net: ethernet: octeon_mgmt: Account for second possible VLAN header | expand

Commit Message

Alexander A Sverdlin Nov. 6, 2019, 3:32 p.m. UTC 
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>

Octeon's input ring-buffer entry has 14 bits-wide size field, so to account
for second possible VLAN header max_mtu must be further reduced.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
 drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Nov. 7, 2019, 11:14 p.m. UTC | #1 
From: "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>
Date: Wed, 6 Nov 2019 15:32:01 +0000

> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 
> Octeon's input ring-buffer entry has 14 bits-wide size field, so to account
> for second possible VLAN header max_mtu must be further reduced.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

Please repost this with an appropriate Fixes: tag added.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
index 0e5de88..cdd7e5d 100644
--- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
@@ -1499,7 +1499,7 @@  static int octeon_mgmt_probe(struct platform_device *pdev)
 	netdev->ethtool_ops = &octeon_mgmt_ethtool_ops;
 
 	netdev->min_mtu = 64 - OCTEON_MGMT_RX_HEADROOM;
-	netdev->max_mtu = 16383 - OCTEON_MGMT_RX_HEADROOM;
+	netdev->max_mtu = 16383 - OCTEON_MGMT_RX_HEADROOM - VLAN_HLEN;
 
 	mac = of_get_mac_address(pdev->dev.of_node);