diff mbox series

[v2,6/6] net: phy: at803x: remove config_init for AR9331

Message ID 20191106223617.1655-7-michael@walle.cc
State Accepted
Delegated to: David Miller
Headers show
Series net: phy: at803x device tree binding | expand

Commit Message

Michael Walle Nov. 6, 2019, 10:36 p.m. UTC 
According to its datasheet, the internal PHY doesn't have debug
registers nor MMDs. Since config_init() only configures delays and
clocks and so on in these registers it won't be needed on this PHY.
Remove it.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/net/phy/at803x.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andrew Lunn Nov. 7, 2019, 2:05 a.m. UTC | #1 
On Wed, Nov 06, 2019 at 11:36:17PM +0100, Michael Walle wrote:
> According to its datasheet, the internal PHY doesn't have debug
> registers nor MMDs. Since config_init() only configures delays and
> clocks and so on in these registers it won't be needed on this PHY.
> Remove it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 4434d501cd4f..aee62610bade 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -755,8 +755,6 @@  static struct phy_driver at803x_driver[] = {
 	/* ATHEROS AR9331 */
 	PHY_ID_MATCH_EXACT(ATH9331_PHY_ID),
 	.name			= "Qualcomm Atheros AR9331 built-in PHY",
-	.probe			= at803x_probe,
-	.config_init		= at803x_config_init,
 	.suspend		= at803x_suspend,
 	.resume			= at803x_resume,
 	/* PHY_BASIC_FEATURES */