| Message ID | 20191031065737.23470-2-ajd@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] templates: Get rid of type attribute in script tags | expand |
On Thu, 2019-10-31 at 17:57 +1100, Andrew Donnellan wrote: > Specifying language in the <html> tag is recommended in HTML5. > > Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > templates/base.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/templates/base.html b/templates/base.html > index 01b0d6b5e598..40b6cda65350 100644 > --- a/templates/base.html > +++ b/templates/base.html > @@ -1,6 +1,6 @@ > {% load static %} > <!DOCTYPE html> > -<html xmlns="http://www.w3.org/1999/xhtml"> > +<html xmlns="http://www.w3.org/1999/xhtml" lang="en-AU"> It's a nit and I know this is applied, but can we change this to en-US? We've a large international audience working on and using Patchwork, and I think all of our UI should be written with US spelling in mind. en-AU doesn't mean anything to me, personally. Stephen > <head> > <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> > <title>{% block title %}Patchwork{% endblock %} - Patchwork</title>
Stephen Finucane <stephen@that.guru> writes: > On Thu, 2019-10-31 at 17:57 +1100, Andrew Donnellan wrote: >> Specifying language in the <html> tag is recommended in HTML5. >> >> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> >> --- >> templates/base.html | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/templates/base.html b/templates/base.html >> index 01b0d6b5e598..40b6cda65350 100644 >> --- a/templates/base.html >> +++ b/templates/base.html >> @@ -1,6 +1,6 @@ >> {% load static %} >> <!DOCTYPE html> >> -<html xmlns="http://www.w3.org/1999/xhtml"> >> +<html xmlns="http://www.w3.org/1999/xhtml" lang="en-AU"> > > It's a nit and I know this is applied, but can we change this to en-US? > We've a large international audience working on and using Patchwork, > and I think all of our UI should be written with US spelling in mind. > en-AU doesn't mean anything to me, personally. I think this is a nice nod to the original authorship of Patchwork (Australian) and the original and longest running deployment (OzLabs, Australia). I also think the internet already has enough American localisation :) I'd be happy to see this moved into a settings file like the default timezone, then sites can override it. Daniel > Stephen > >> <head> >> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> >> <title>{% block title %}Patchwork{% endblock %} - Patchwork</title> > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
On Wed, 2019-11-06 at 17:17 +1100, Daniel Axtens wrote: > Stephen Finucane <stephen@that.guru> writes: > > > On Thu, 2019-10-31 at 17:57 +1100, Andrew Donnellan wrote: > > > Specifying language in the <html> tag is recommended in HTML5. > > > > > > Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> > > > --- > > > templates/base.html | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/templates/base.html b/templates/base.html > > > index 01b0d6b5e598..40b6cda65350 100644 > > > --- a/templates/base.html > > > +++ b/templates/base.html > > > @@ -1,6 +1,6 @@ > > > {% load static %} > > > <!DOCTYPE html> > > > -<html xmlns="http://www.w3.org/1999/xhtml"> > > > +<html xmlns="http://www.w3.org/1999/xhtml" lang="en-AU"> > > > > It's a nit and I know this is applied, but can we change this to en-US? > > We've a large international audience working on and using Patchwork, > > and I think all of our UI should be written with US spelling in mind. > > en-AU doesn't mean anything to me, personally. > > I think this is a nice nod to the original authorship of Patchwork > (Australian) and the original and longest running deployment (OzLabs, > Australia). > > I also think the internet already has enough American localisation :) > > I'd be happy to see this moved into a settings file like the default > timezone, then sites can override it. We already have LANGUAGE_CODE so we can use that. With that said, our UI and docs are written in US English (or should be), given our international audience and the use of US English as the lingua franca. As such, does it make sense to actually provide a way to override this since e.g. someone could set it ru-RU which would be totally wrong (as opposed to en-AU or en-IE, which is merely slightly wrong). Stephen > Daniel > > > Stephen > > > > > <head> > > > <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> > > > <title>{% block title %}Patchwork{% endblock %} - Patchwork</title> > > > > _______________________________________________ > > Patchwork mailing list > > Patchwork@lists.ozlabs.org > > https://lists.ozlabs.org/listinfo/patchwork
diff --git a/templates/base.html b/templates/base.html index 01b0d6b5e598..40b6cda65350 100644 --- a/templates/base.html +++ b/templates/base.html @@ -1,6 +1,6 @@ {% load static %} <!DOCTYPE html> -<html xmlns="http://www.w3.org/1999/xhtml"> +<html xmlns="http://www.w3.org/1999/xhtml" lang="en-AU"> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> <title>{% block title %}Patchwork{% endblock %} - Patchwork</title>
Specifying language in the <html> tag is recommended in HTML5. Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> --- templates/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)