| Message ID | 20191030224251.21578-2-michael@walle.cc |
|---|---|
| State | RFC |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: at803x device tree binding | expand |
On Wed, Oct 30, 2019 at 11:42:49PM +0100, Michael Walle wrote: > The name of the PHY is actually AR803x not AT803x. Additionally, add the > name of the vendor and mention the AR8031 support. > > Signed-off-by: Michael Walle <michael@walle.cc> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 10/30/19 3:42 PM, Michael Walle wrote: > The name of the PHY is actually AR803x not AT803x. Additionally, add the > name of the vendor and mention the AR8031 support. Should not the vendor be QCA these days, or Qualcomm Atheros? > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > drivers/net/phy/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index fe602648b99f..38f180f9ca42 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -283,9 +283,9 @@ config AX88796B_PHY > AX88796B package. > > config AT803X_PHY > - tristate "AT803X PHYs" > + tristate "Atheros AR803X PHYs" > ---help--- > - Currently supports the AT8030 and AT8035 model > + Currently supports the AR8030, AR8031 and AR8035 model > > config BCM63XX_PHY > tristate "Broadcom 63xx SOCs internal PHY" >
On Wed, Oct 30, 2019 at 04:16:01PM -0700, Florian Fainelli wrote: > On 10/30/19 3:42 PM, Michael Walle wrote: > > The name of the PHY is actually AR803x not AT803x. Additionally, add the > > name of the vendor and mention the AR8031 support. > > Should not the vendor be QCA these days, or Qualcomm Atheros? Atheros Qualcomm would work best in terms of not upsetting the sort order. Andrew
On 10/30/19 4:18 PM, Andrew Lunn wrote: > On Wed, Oct 30, 2019 at 04:16:01PM -0700, Florian Fainelli wrote: >> On 10/30/19 3:42 PM, Michael Walle wrote: >>> The name of the PHY is actually AR803x not AT803x. Additionally, add the >>> name of the vendor and mention the AR8031 support. >> >> Should not the vendor be QCA these days, or Qualcomm Atheros? > > Atheros Qualcomm would work best in terms of not upsetting the sort > order. Yes except the company is actually named Qualcomm Atheros: https://en.wikipedia.org/wiki/Qualcomm_Atheros
Am 31. Oktober 2019 00:32:15 MEZ schrieb Florian Fainelli <f.fainelli@gmail.com>: >On 10/30/19 4:18 PM, Andrew Lunn wrote: >> On Wed, Oct 30, 2019 at 04:16:01PM -0700, Florian Fainelli wrote: >>> On 10/30/19 3:42 PM, Michael Walle wrote: >>>> The name of the PHY is actually AR803x not AT803x. Additionally, >add the >>>> name of the vendor and mention the AR8031 support. >>> >>> Should not the vendor be QCA these days, or Qualcomm Atheros? >> >> Atheros Qualcomm would work best in terms of not upsetting the sort >> order. > >Yes except the company is actually named Qualcomm Atheros: > >https://en.wikipedia.org/wiki/Qualcomm_Atheros Correct.. my bad. also the atheros prefix is wrong then.. because there is already a qca prefix. but.. should i also reorder the entry in the Kconfig then? -michael
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index fe602648b99f..38f180f9ca42 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -283,9 +283,9 @@ config AX88796B_PHY AX88796B package. config AT803X_PHY - tristate "AT803X PHYs" + tristate "Atheros AR803X PHYs" ---help--- - Currently supports the AT8030 and AT8035 model + Currently supports the AR8030, AR8031 and AR8035 model config BCM63XX_PHY tristate "Broadcom 63xx SOCs internal PHY"
The name of the PHY is actually AR803x not AT803x. Additionally, add the name of the vendor and mention the AR8031 support. Signed-off-by: Michael Walle <michael@walle.cc> --- drivers/net/phy/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)