Message ID | 20191029122615.7525-1-numans@ovn.org |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev,ovn] Fix system-ovn test failures | expand |
Acked-by: hzhou@ovn.org On Tue, Oct 29, 2019 at 5:26 AM <numans@ovn.org> wrote: > From: Numan Siddique <numans@ovn.org> > > The commit b740928656a1("testsuite: Use ovn-macros instead of > ofproto-macros.") > missed updating the system test suite files to include ovn-macros.at. This > patch adds it. > > CC: Han Zhou <hzhou@ovn.org> > Signed-off-by: Numan Siddique <numans@ovn.org> > --- > tests/system-kmod-testsuite.at | 1 + > tests/system-userspace-testsuite.at | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tests/system-kmod-testsuite.at b/tests/ > system-kmod-testsuite.at > index 6c8478093..2ccd9f1ce 100644 > --- a/tests/system-kmod-testsuite.at > +++ b/tests/system-kmod-testsuite.at > @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) > m4_include([tests/ovs-macros.at]) > m4_include([tests/ovsdb-macros.at]) > m4_include([tests/ofproto-macros.at]) > +m4_include([tests/ovn-macros.at]) > m4_include([tests/system-common-macros.at]) > m4_include([tests/system-kmod-macros.at]) > > diff --git a/tests/system-userspace-testsuite.at b/tests/ > system-userspace-testsuite.at > index 784eedd2c..4022ae620 100644 > --- a/tests/system-userspace-testsuite.at > +++ b/tests/system-userspace-testsuite.at > @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) > m4_include([tests/ovs-macros.at]) > m4_include([tests/ovsdb-macros.at]) > m4_include([tests/ofproto-macros.at]) > +m4_include([tests/ovn-macros.at]) > m4_include([tests/system-userspace-macros.at]) > m4_include([tests/system-common-macros.at]) > > -- > 2.21.0 > >
Thanks, I just hit this and the patch fixes it for me. Acked-by: Russell Bryant <russell@ovn.org> On Tue, Oct 29, 2019 at 9:56 AM Han Zhou <hzhou@ovn.org> wrote: > > Acked-by: hzhou@ovn.org > > On Tue, Oct 29, 2019 at 5:26 AM <numans@ovn.org> wrote: > > > From: Numan Siddique <numans@ovn.org> > > > > The commit b740928656a1("testsuite: Use ovn-macros instead of > > ofproto-macros.") > > missed updating the system test suite files to include ovn-macros.at. This > > patch adds it. > > > > CC: Han Zhou <hzhou@ovn.org> > > Signed-off-by: Numan Siddique <numans@ovn.org> > > --- > > tests/system-kmod-testsuite.at | 1 + > > tests/system-userspace-testsuite.at | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/tests/system-kmod-testsuite.at b/tests/ > > system-kmod-testsuite.at > > index 6c8478093..2ccd9f1ce 100644 > > --- a/tests/system-kmod-testsuite.at > > +++ b/tests/system-kmod-testsuite.at > > @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) > > m4_include([tests/ovs-macros.at]) > > m4_include([tests/ovsdb-macros.at]) > > m4_include([tests/ofproto-macros.at]) > > +m4_include([tests/ovn-macros.at]) > > m4_include([tests/system-common-macros.at]) > > m4_include([tests/system-kmod-macros.at]) > > > > diff --git a/tests/system-userspace-testsuite.at b/tests/ > > system-userspace-testsuite.at > > index 784eedd2c..4022ae620 100644 > > --- a/tests/system-userspace-testsuite.at > > +++ b/tests/system-userspace-testsuite.at > > @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) > > m4_include([tests/ovs-macros.at]) > > m4_include([tests/ovsdb-macros.at]) > > m4_include([tests/ofproto-macros.at]) > > +m4_include([tests/ovn-macros.at]) > > m4_include([tests/system-userspace-macros.at]) > > m4_include([tests/system-common-macros.at]) > > > > -- > > 2.21.0 > > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Oct 29, 2019 at 8:16 PM Russell Bryant <russell@ovn.org> wrote: > > Thanks, I just hit this and the patch fixes it for me. > > Acked-by: Russell Bryant <russell@ovn.org> Thanks for the reviews. I applied this patch to master. Numan > > On Tue, Oct 29, 2019 at 9:56 AM Han Zhou <hzhou@ovn.org> wrote: > > > > Acked-by: hzhou@ovn.org > > > > On Tue, Oct 29, 2019 at 5:26 AM <numans@ovn.org> wrote: > > > > > From: Numan Siddique <numans@ovn.org> > > > > > > The commit b740928656a1("testsuite: Use ovn-macros instead of > > > ofproto-macros.") > > > missed updating the system test suite files to include ovn-macros.at. This > > > patch adds it. > > > > > > CC: Han Zhou <hzhou@ovn.org> > > > Signed-off-by: Numan Siddique <numans@ovn.org> > > > --- > > > tests/system-kmod-testsuite.at | 1 + > > > tests/system-userspace-testsuite.at | 1 + > > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/tests/system-kmod-testsuite.at b/tests/ > > > system-kmod-testsuite.at > > > index 6c8478093..2ccd9f1ce 100644 > > > --- a/tests/system-kmod-testsuite.at > > > +++ b/tests/system-kmod-testsuite.at > > > @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) > > > m4_include([tests/ovs-macros.at]) > > > m4_include([tests/ovsdb-macros.at]) > > > m4_include([tests/ofproto-macros.at]) > > > +m4_include([tests/ovn-macros.at]) > > > m4_include([tests/system-common-macros.at]) > > > m4_include([tests/system-kmod-macros.at]) > > > > > > diff --git a/tests/system-userspace-testsuite.at b/tests/ > > > system-userspace-testsuite.at > > > index 784eedd2c..4022ae620 100644 > > > --- a/tests/system-userspace-testsuite.at > > > +++ b/tests/system-userspace-testsuite.at > > > @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) > > > m4_include([tests/ovs-macros.at]) > > > m4_include([tests/ovsdb-macros.at]) > > > m4_include([tests/ofproto-macros.at]) > > > +m4_include([tests/ovn-macros.at]) > > > m4_include([tests/system-userspace-macros.at]) > > > m4_include([tests/system-common-macros.at]) > > > > > > -- > > > 2.21.0 > > > > > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > -- > Russell Bryant > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/tests/system-kmod-testsuite.at b/tests/system-kmod-testsuite.at index 6c8478093..2ccd9f1ce 100644 --- a/tests/system-kmod-testsuite.at +++ b/tests/system-kmod-testsuite.at @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) m4_include([tests/ovs-macros.at]) m4_include([tests/ovsdb-macros.at]) m4_include([tests/ofproto-macros.at]) +m4_include([tests/ovn-macros.at]) m4_include([tests/system-common-macros.at]) m4_include([tests/system-kmod-macros.at]) diff --git a/tests/system-userspace-testsuite.at b/tests/system-userspace-testsuite.at index 784eedd2c..4022ae620 100644 --- a/tests/system-userspace-testsuite.at +++ b/tests/system-userspace-testsuite.at @@ -19,6 +19,7 @@ m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) m4_include([tests/ovs-macros.at]) m4_include([tests/ovsdb-macros.at]) m4_include([tests/ofproto-macros.at]) +m4_include([tests/ovn-macros.at]) m4_include([tests/system-userspace-macros.at]) m4_include([tests/system-common-macros.at])