Message ID | 1302015561-21047-18-git-send-email-mmarek@suse.cz |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
Am 05.04.2011 16:59, schrieb Michal Marek: > The kernel already prints its build timestamp during boot, no need to > repeat it in random drivers and produce different object files each > time. > > Cc: Thomas Sailer <t.sailer@alumni.ethz.ch> > Cc: linux-hams@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Michal Marek <mmarek@suse.cz> > --- > drivers/net/hamradio/hdlcdrv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c > index 5b37579..a4a3516 100644 > --- a/drivers/net/hamradio/hdlcdrv.c > +++ b/drivers/net/hamradio/hdlcdrv.c > @@ -749,7 +749,7 @@ EXPORT_SYMBOL(hdlcdrv_unregister); > static int __init hdlcdrv_init_driver(void) > { > printk(KERN_INFO "hdlcdrv: (C) 1996-2000 Thomas Sailer HB9JNX/AE4WA\n"); > - printk(KERN_INFO "hdlcdrv: version 0.8 compiled " __TIME__ " " __DATE__ "\n"); > + printk(KERN_INFO "hdlcdrv: version 0.8\n"); > return 0; > } > Its a bit late but i am not a big fan of hard coded version id's. Does GIT provide something like that ? If not IMHO the line printk(KERN_INFO "hdlcdrv: version 0.8\n"); can be removed. re, wh -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19.4.2011 12:17, walter harms wrote: > Am 05.04.2011 16:59, schrieb Michal Marek: >> --- a/drivers/net/hamradio/hdlcdrv.c >> +++ b/drivers/net/hamradio/hdlcdrv.c >> @@ -749,7 +749,7 @@ EXPORT_SYMBOL(hdlcdrv_unregister); >> static int __init hdlcdrv_init_driver(void) >> { >> printk(KERN_INFO "hdlcdrv: (C) 1996-2000 Thomas Sailer HB9JNX/AE4WA\n"); >> - printk(KERN_INFO "hdlcdrv: version 0.8 compiled " __TIME__ " " __DATE__ "\n"); >> + printk(KERN_INFO "hdlcdrv: version 0.8\n"); >> return 0; >> } >> > > Its a bit late but i am not a big fan of hard coded version id's. > Does GIT provide something like that ? If not > IMHO the line > printk(KERN_INFO "hdlcdrv: version 0.8\n"); > can be removed. OK, submit a separate patch then. I personally don't care about version id's, as long as they do not embed any timestamp ;-). Michal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5.4.2011 17:03, Thomas Sailer wrote: > On Tue, 2011-04-05 at 16:59 +0200, Michal Marek wrote: >> The kernel already prints its build timestamp during boot, no need to >> repeat it in random drivers and produce different object files each >> time. >> >> Cc: Thomas Sailer<t.sailer@alumni.ethz.ch> >> Cc: linux-hams@vger.kernel.org >> Cc: netdev@vger.kernel.org >> Signed-off-by: Michal Marek<mmarek@suse.cz> > Acked-By: Thomas Sailer<t.sailer@alumni.ethz.ch> > > Ok with me I didn't find the commit in today's linux-next, so I applied this to kbuild-2.6.git#trivial. Michal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c index 5b37579..a4a3516 100644 --- a/drivers/net/hamradio/hdlcdrv.c +++ b/drivers/net/hamradio/hdlcdrv.c @@ -749,7 +749,7 @@ EXPORT_SYMBOL(hdlcdrv_unregister); static int __init hdlcdrv_init_driver(void) { printk(KERN_INFO "hdlcdrv: (C) 1996-2000 Thomas Sailer HB9JNX/AE4WA\n"); - printk(KERN_INFO "hdlcdrv: version 0.8 compiled " __TIME__ " " __DATE__ "\n"); + printk(KERN_INFO "hdlcdrv: version 0.8\n"); return 0; }
The kernel already prints its build timestamp during boot, no need to repeat it in random drivers and produce different object files each time. Cc: Thomas Sailer <t.sailer@alumni.ethz.ch> Cc: linux-hams@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- drivers/net/hamradio/hdlcdrv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)