mbox series

[net-next,v10,0/3] net: phy: support 1000Base-X auto-negotiation for BCM54616S

Message ID 20191022183108.14029-1-rentao.bupt@gmail.com
Headers show
Series net: phy: support 1000Base-X auto-negotiation for BCM54616S | expand

Message

Tao Ren Oct. 22, 2019, 6:31 p.m. UTC
From: Tao Ren <rentao.bupt@gmail.com>

This patch series aims at supporting auto negotiation when BCM54616S is
running in 1000Base-X mode: without the patch series, BCM54616S PHY driver
would report incorrect link speed in 1000Base-X mode.

Patch #1 (of 3) modifies assignment to OR when dealing with dev_flags in
phy_attach_direct function, so that dev_flags updated in BCM54616S PHY's
probe callback won't be lost.

Patch #2 (of 3) adds several genphy_c37_* functions to support clause 37
1000Base-X auto-negotiation, and these functions are called in BCM54616S
PHY driver.

Patch #3 (of 3) detects BCM54616S PHY's operation mode and calls according
genphy_c37_* functions to configure auto-negotiation and parse link
attributes (speed, duplex, and etc.) in 1000Base-X mode.

Heiner Kallweit (1):
  net: phy: add support for clause 37 auto-negotiation

Tao Ren (2):
  net: phy: modify assignment to OR for dev_flags in phy_attach_direct
  net: phy: broadcom: add 1000Base-X support for BCM54616S

 drivers/net/phy/broadcom.c   |  57 +++++++++++++-
 drivers/net/phy/phy_device.c | 141 ++++++++++++++++++++++++++++++++++-
 include/linux/brcmphy.h      |  10 ++-
 include/linux/phy.h          |   4 +
 4 files changed, 205 insertions(+), 7 deletions(-)

Comments

David Miller Oct. 24, 2019, 3:43 a.m. UTC | #1
From: rentao.bupt@gmail.com
Date: Tue, 22 Oct 2019 11:31:05 -0700

> From: Tao Ren <rentao.bupt@gmail.com>
> 
> This patch series aims at supporting auto negotiation when BCM54616S is
> running in 1000Base-X mode: without the patch series, BCM54616S PHY driver
> would report incorrect link speed in 1000Base-X mode.
> 
> Patch #1 (of 3) modifies assignment to OR when dealing with dev_flags in
> phy_attach_direct function, so that dev_flags updated in BCM54616S PHY's
> probe callback won't be lost.
> 
> Patch #2 (of 3) adds several genphy_c37_* functions to support clause 37
> 1000Base-X auto-negotiation, and these functions are called in BCM54616S
> PHY driver.
> 
> Patch #3 (of 3) detects BCM54616S PHY's operation mode and calls according
> genphy_c37_* functions to configure auto-negotiation and parse link
> attributes (speed, duplex, and etc.) in 1000Base-X mode.

Series applied to net-next, thank you.
Tao Ren Oct. 24, 2019, 6:29 a.m. UTC | #2
On Wed, Oct 23, 2019 at 08:43:11PM -0700, David Miller wrote:
> From: rentao.bupt@gmail.com
> Date: Tue, 22 Oct 2019 11:31:05 -0700
> 
> > From: Tao Ren <rentao.bupt@gmail.com>
> > 
> > This patch series aims at supporting auto negotiation when BCM54616S is
> > running in 1000Base-X mode: without the patch series, BCM54616S PHY driver
> > would report incorrect link speed in 1000Base-X mode.
> > 
> > Patch #1 (of 3) modifies assignment to OR when dealing with dev_flags in
> > phy_attach_direct function, so that dev_flags updated in BCM54616S PHY's
> > probe callback won't be lost.
> > 
> > Patch #2 (of 3) adds several genphy_c37_* functions to support clause 37
> > 1000Base-X auto-negotiation, and these functions are called in BCM54616S
> > PHY driver.
> > 
> > Patch #3 (of 3) detects BCM54616S PHY's operation mode and calls according
> > genphy_c37_* functions to configure auto-negotiation and parse link
> > attributes (speed, duplex, and etc.) in 1000Base-X mode.
> 
> Series applied to net-next, thank you.

Great. Thank you David!


Cheers,

Tao