mbox series

[U-Boot,v2,0/4] Fix default values for address and size cells

Message ID 20190905084849.20596-1-matthias.bgg@kernel.org
Headers show
Series Fix default values for address and size cells | expand

Message

Matthias Brugger Sept. 5, 2019, 8:48 a.m. UTC
From: Matthias Brugger <mbrugger@suse.com>

The libftd implementation of U-Boot is outdated with the
upstream project. Especially the default number of size-cells
was wrong. This series fixes this by backporting the corresponding
patches from the upstream project.

Changes since v1:
- fix spelling of U-Boot (patch 1 + 2 /4)
- add Reviewed-by tag (patch 1/4)
- fix the case of size-cells == 0 (patch 3/4)
- fix default address cells for livetree (patch 4/4)

v1 can be found here:
https://patchwork.ozlabs.org/patch/1137331/
https://patchwork.ozlabs.org/patch/1137330/


Matthias Brugger (4):
  libfdt: fdt_address_cells() and fdt_size_cells()
  libfdt: return correct value if #size-cells property is not present
  libfdt: Allow #size-cells of 0
  dm: Fix default address cells return value

 include/dm/of.h                    |  2 +-
 scripts/dtc/libfdt/fdt_addresses.c | 45 ++++++++++++++++--------------
 scripts/dtc/libfdt/libfdt.h        |  2 +-
 3 files changed, 26 insertions(+), 23 deletions(-)

Comments

Matthias Brugger Sept. 25, 2019, 9:57 a.m. UTC | #1
Hi Simon,

On 05/09/2019 10:48, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> The libftd implementation of U-Boot is outdated with the
> upstream project. Especially the default number of size-cells
> was wrong. This series fixes this by backporting the corresponding
> patches from the upstream project.
> 
> Changes since v1:
> - fix spelling of U-Boot (patch 1 + 2 /4)
> - add Reviewed-by tag (patch 1/4)
> - fix the case of size-cells == 0 (patch 3/4)
> - fix default address cells for livetree (patch 4/4)
> 
> v1 can be found here:
> https://patchwork.ozlabs.org/patch/1137331/
> https://patchwork.ozlabs.org/patch/1137330/
> 
> 
> Matthias Brugger (4):
>   libfdt: fdt_address_cells() and fdt_size_cells()
>   libfdt: return correct value if #size-cells property is not present
>   libfdt: Allow #size-cells of 0
>   dm: Fix default address cells return value
> 
>  include/dm/of.h                    |  2 +-
>  scripts/dtc/libfdt/fdt_addresses.c | 45 ++++++++++++++++--------------
>  scripts/dtc/libfdt/libfdt.h        |  2 +-
>  3 files changed, 26 insertions(+), 23 deletions(-)
> 

Any comments on this? I tried to find your custodian tree, but wasn't able to do
so and check if you took it already.

Regards,
Matthias
Simon Glass Oct. 21, 2019, 11:47 p.m. UTC | #2
Hi Matthias,

On Wed, 25 Sep 2019 at 03:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
> Hi Simon,
>
> On 05/09/2019 10:48, matthias.bgg@kernel.org wrote:
> > From: Matthias Brugger <mbrugger@suse.com>
> >
> > The libftd implementation of U-Boot is outdated with the
> > upstream project. Especially the default number of size-cells
> > was wrong. This series fixes this by backporting the corresponding
> > patches from the upstream project.
> >
> > Changes since v1:
> > - fix spelling of U-Boot (patch 1 + 2 /4)
> > - add Reviewed-by tag (patch 1/4)
> > - fix the case of size-cells == 0 (patch 3/4)
> > - fix default address cells for livetree (patch 4/4)
> >
> > v1 can be found here:
> > https://patchwork.ozlabs.org/patch/1137331/
> > https://patchwork.ozlabs.org/patch/1137330/
> >
> >
> > Matthias Brugger (4):
> >   libfdt: fdt_address_cells() and fdt_size_cells()
> >   libfdt: return correct value if #size-cells property is not present
> >   libfdt: Allow #size-cells of 0
> >   dm: Fix default address cells return value
> >
> >  include/dm/of.h                    |  2 +-
> >  scripts/dtc/libfdt/fdt_addresses.c | 45 ++++++++++++++++--------------
> >  scripts/dtc/libfdt/libfdt.h        |  2 +-
> >  3 files changed, 26 insertions(+), 23 deletions(-)
> >
>
> Any comments on this? I tried to find your custodian tree, but wasn't able to do
> so and check if you took it already.

This was applied. Did you not get the emails on each patch?

Regards,
Simon
Matthias Brugger Oct. 22, 2019, 11:14 a.m. UTC | #3
On 22/10/2019 01:47, Simon Glass wrote:
> Hi Matthias,
> 
> On Wed, 25 Sep 2019 at 03:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>> Hi Simon,
>>
>> On 05/09/2019 10:48, matthias.bgg@kernel.org wrote:
>>> From: Matthias Brugger <mbrugger@suse.com>
>>>
>>> The libftd implementation of U-Boot is outdated with the
>>> upstream project. Especially the default number of size-cells
>>> was wrong. This series fixes this by backporting the corresponding
>>> patches from the upstream project.
>>>
>>> Changes since v1:
>>> - fix spelling of U-Boot (patch 1 + 2 /4)
>>> - add Reviewed-by tag (patch 1/4)
>>> - fix the case of size-cells == 0 (patch 3/4)
>>> - fix default address cells for livetree (patch 4/4)
>>>
>>> v1 can be found here:
>>> https://patchwork.ozlabs.org/patch/1137331/
>>> https://patchwork.ozlabs.org/patch/1137330/
>>>
>>>
>>> Matthias Brugger (4):
>>>   libfdt: fdt_address_cells() and fdt_size_cells()
>>>   libfdt: return correct value if #size-cells property is not present
>>>   libfdt: Allow #size-cells of 0
>>>   dm: Fix default address cells return value
>>>
>>>  include/dm/of.h                    |  2 +-
>>>  scripts/dtc/libfdt/fdt_addresses.c | 45 ++++++++++++++++--------------
>>>  scripts/dtc/libfdt/libfdt.h        |  2 +-
>>>  3 files changed, 26 insertions(+), 23 deletions(-)
>>>
>>
>> Any comments on this? I tried to find your custodian tree, but wasn't able to do
>> so and check if you took it already.
> 
> This was applied. Did you not get the emails on each patch?
> 

I got emails saying that they were applied to u-boot-dm/next, but wasn't able to
find that branch.

Seeing it now, not sure if I didn't look correctly. Anyway thank for merging
these fixes.

Regards,
Matthias