mbox series

[v4,0/3] PCI: Add Intel PCIe Driver and respective dt-binding yaml file

Message ID cover.1571638827.git.eswara.kota@linux.intel.com
Headers show
Series PCI: Add Intel PCIe Driver and respective dt-binding yaml file | expand

Message

Dilip Kota Oct. 21, 2019, 6:39 a.m. UTC
Intel PCIe is synopsys based controller utilizes the Designware
framework for host initialization and intel application
specific register configurations.

Changes on v4:
	Add lane resizing API in PCIe DesignWare driver.
	Intel PCIe driver uses it for lane resizing which
	 is being exposed through sysfs attributes.
	Add Intel PCIe sysfs attributes is in separate patch.
	Address review comments given on v3.

Changes on v3:
	Compared to v2, map_irq() patch is removed as it is no longer
	  required for Intel PCIe driver. Intel PCIe driver does platform
	  specific interrupt configuration during core initialization. So
	  changed the subject line too.
	Address v2 review comments for DT binding and PCIe driver

Dilip Kota (3):
  dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller
  dwc: PCI: intel: PCIe RC controller driver
  pci: intel: Add sysfs attributes to configure pcie link

 .../devicetree/bindings/pci/intel-gw-pcie.yaml     | 135 ++++
 drivers/pci/controller/dwc/Kconfig                 |  10 +
 drivers/pci/controller/dwc/Makefile                |   1 +
 drivers/pci/controller/dwc/pcie-designware.c       |  43 ++
 drivers/pci/controller/dwc/pcie-designware.h       |  15 +
 drivers/pci/controller/dwc/pcie-intel-gw.c         | 700 +++++++++++++++
 include/uapi/linux/pci_regs.h                      |   1 +
 7 files changed, 905 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
 create mode 100644 drivers/pci/controller/dwc/pcie-intel-gw.c

Comments

Gustavo Pimentel Oct. 21, 2019, 8:08 a.m. UTC | #1
Hi,


On Mon, Oct 21, 2019 at 7:39:17, Dilip Kota <eswara.kota@linux.intel.com> 
wrote:

> Intel PCIe is synopsys based controller utilizes the Designware

Please do this general replacement in all your patches.

s/synopsys/Synopsys

and

s/Designware/DesignWare

> framework for host initialization and intel application
> specific register configurations.
> 
> Changes on v4:
> 	Add lane resizing API in PCIe DesignWare driver.
> 	Intel PCIe driver uses it for lane resizing which
> 	 is being exposed through sysfs attributes.
> 	Add Intel PCIe sysfs attributes is in separate patch.
> 	Address review comments given on v3.
> 
> Changes on v3:
> 	Compared to v2, map_irq() patch is removed as it is no longer
> 	  required for Intel PCIe driver. Intel PCIe driver does platform
> 	  specific interrupt configuration during core initialization. So
> 	  changed the subject line too.
> 	Address v2 review comments for DT binding and PCIe driver
> 
> Dilip Kota (3):
>   dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller
>   dwc: PCI: intel: PCIe RC controller driver
>   pci: intel: Add sysfs attributes to configure pcie link
> 
>  .../devicetree/bindings/pci/intel-gw-pcie.yaml     | 135 ++++
>  drivers/pci/controller/dwc/Kconfig                 |  10 +
>  drivers/pci/controller/dwc/Makefile                |   1 +
>  drivers/pci/controller/dwc/pcie-designware.c       |  43 ++
>  drivers/pci/controller/dwc/pcie-designware.h       |  15 +
>  drivers/pci/controller/dwc/pcie-intel-gw.c         | 700 +++++++++++++++
>  include/uapi/linux/pci_regs.h                      |   1 +
>  7 files changed, 905 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
>  create mode 100644 drivers/pci/controller/dwc/pcie-intel-gw.c
> 
> -- 
> 2.11.0
Dilip Kota Oct. 21, 2019, 8:31 a.m. UTC | #2
Hi Gustavo Pimentel,

On 10/21/2019 4:08 PM, Gustavo Pimentel wrote:
> Hi,
>
>
> On Mon, Oct 21, 2019 at 7:39:17, Dilip Kota <eswara.kota@linux.intel.com>
> wrote:
>
>> Intel PCIe is synopsys based controller utilizes the Designware
> Please do this general replacement in all your patches.
>
> s/synopsys/Synopsys
>
> and
>
> s/Designware/DesignWare
Sure, i will update it in the next patch version.
(In the all other patches naming is proper, i got missed it here.)
I will ensure and take care of it.

Regards,
Dilip

>
>> framework for host initialization and intel application
>> specific register configurations.
>>
>> Changes on v4:
>> 	Add lane resizing API in PCIe DesignWare driver.
>> 	Intel PCIe driver uses it for lane resizing which
>> 	 is being exposed through sysfs attributes.
>> 	Add Intel PCIe sysfs attributes is in separate patch.
>> 	Address review comments given on v3.
>>
>> Changes on v3:
>> 	Compared to v2, map_irq() patch is removed as it is no longer
>> 	  required for Intel PCIe driver. Intel PCIe driver does platform
>> 	  specific interrupt configuration during core initialization. So
>> 	  changed the subject line too.
>> 	Address v2 review comments for DT binding and PCIe driver
>>
>> Dilip Kota (3):
>>    dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller
>>    dwc: PCI: intel: PCIe RC controller driver
>>    pci: intel: Add sysfs attributes to configure pcie link
>>
>>   .../devicetree/bindings/pci/intel-gw-pcie.yaml     | 135 ++++
>>   drivers/pci/controller/dwc/Kconfig                 |  10 +
>>   drivers/pci/controller/dwc/Makefile                |   1 +
>>   drivers/pci/controller/dwc/pcie-designware.c       |  43 ++
>>   drivers/pci/controller/dwc/pcie-designware.h       |  15 +
>>   drivers/pci/controller/dwc/pcie-intel-gw.c         | 700 +++++++++++++++
>>   include/uapi/linux/pci_regs.h                      |   1 +
>>   7 files changed, 905 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
>>   create mode 100644 drivers/pci/controller/dwc/pcie-intel-gw.c
>>
>> -- 
>> 2.11.0
>