| Message ID | 20191009194740.8079-3-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | iotests: trivial cleanups | expand |
Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben: > Should not be necessary on files that are not executed standalone. > > Reviewed-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Cleber Rosa <crosa@redhat.com> Looks fine for common.filter and common.rc, nobody ever checks their return value. common.config is included like this: if ! . "$source_iotests/common.config" then _init_error "failed to source common.config" fi So as long as we keep this, don't we want to make sure that it returns success? Of course, we never really want to return an error from common.config, so instead of keeping the final 'true' statement, we might consider changing its inclusion to not check for errors. The case that potentially changes is when common.config doesn't exist or isn't readable, but this isn't supposed to ever happen anyway. Kevin
diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config index b85a6a6f96..47605d61e2 100644 --- a/tests/qemu-iotests/common.config +++ b/tests/qemu-iotests/common.config @@ -36,6 +36,3 @@ _optstr_add() echo "$2" fi } - -# make sure this script returns success -true diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index a0b52b0ac8..60f675251a 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -226,6 +226,3 @@ _filter_qmp_empty_return() { grep -v '{"return": {}}' } - -# make sure this script returns success -true diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index aa4a7fcc11..3fd4330dbd 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -602,6 +602,3 @@ _require_drivers() fi done } - -# make sure this script returns success -true