Message ID | 20190930152658.18236-3-sebastien.szymanski@armadeus.com |
---|---|
State | Superseded |
Delegated to: | Stefano Babic |
Headers | show |
Series | [U-Boot,1/3] imx6ul: opos6ul: migrate to DM_ETH | expand |
> Subject: [PATCH 3/3] video: mxsfb: set gd->fb_base > > Set gd->fb_base so it can be shown with bdinfo command. > > Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > --- > drivers/video/mxsfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index > 6922a130c6..ce67f3f32b 100644 > --- a/drivers/video/mxsfb.c > +++ b/drivers/video/mxsfb.c > @@ -367,6 +367,7 @@ static int mxs_video_probe(struct udevice *dev) > mmu_set_region_dcache_behaviour(fb_start, fb_end - fb_start, > DCACHE_WRITEBACK); > video_set_flush_dcache(dev, true); > + gd->fb_base = fb_start; Should this be gd->fb_base = plat->base? Regards, Peng. > > return ret; > } > -- > 2.21.0
On Wed, 9 Oct 2019 06:30:36 +0000 Peng Fan peng.fan@nxp.com wrote: ... > > + gd->fb_base = fb_start; > > Should this be gd->fb_base = plat->base? yes, please use plat->base here. -- Anatolij
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 6922a130c6..ce67f3f32b 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -367,6 +367,7 @@ static int mxs_video_probe(struct udevice *dev) mmu_set_region_dcache_behaviour(fb_start, fb_end - fb_start, DCACHE_WRITEBACK); video_set_flush_dcache(dev, true); + gd->fb_base = fb_start; return ret; }
Set gd->fb_base so it can be shown with bdinfo command. Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> --- drivers/video/mxsfb.c | 1 + 1 file changed, 1 insertion(+)