| Message ID | 20191008115143.14149-3-andrew@aj.id.au |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs | expand |
On Tue, 8 Oct 2019 at 11:50, Andrew Jeffery <andrew@aj.id.au> wrote: > > Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is > in use. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt > index 04cc0191b7dd..c443b0b84be5 100644 > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt > @@ -24,6 +24,12 @@ Optional properties: > - no-hw-checksum: Used to disable HW checksum support. Here for backward > compatibility as the driver now should have correct defaults based on > the SoC. > +- clocks: In accordance with the generic clock bindings. Must describe the MAC > + IP clock, and optionally an RMII RCLK gate for the AST2600. or AST2500. With that fixed you can add my ack. > +- clock-names: > + > + - "MACCLK": The MAC IP clock > + - "RCLK": Clock gate for the RMII RCLK > > Example: > > -- > 2.20.1 >
On Tue, 8 Oct 2019, at 23:12, Joel Stanley wrote: > On Tue, 8 Oct 2019 at 11:50, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is > > in use. > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > --- > > Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt > > index 04cc0191b7dd..c443b0b84be5 100644 > > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt > > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt > > @@ -24,6 +24,12 @@ Optional properties: > > - no-hw-checksum: Used to disable HW checksum support. Here for backward > > compatibility as the driver now should have correct defaults based on > > the SoC. > > +- clocks: In accordance with the generic clock bindings. Must describe the MAC > > + IP clock, and optionally an RMII RCLK gate for the AST2600. > > or AST2500. > > With that fixed you can add my ack. I'll do a v2 and fix the comments in the driver patch as well. Cheers, Andrew
diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt index 04cc0191b7dd..c443b0b84be5 100644 --- a/Documentation/devicetree/bindings/net/ftgmac100.txt +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt @@ -24,6 +24,12 @@ Optional properties: - no-hw-checksum: Used to disable HW checksum support. Here for backward compatibility as the driver now should have correct defaults based on the SoC. +- clocks: In accordance with the generic clock bindings. Must describe the MAC + IP clock, and optionally an RMII RCLK gate for the AST2600. +- clock-names: + + - "MACCLK": The MAC IP clock + - "RCLK": Clock gate for the RMII RCLK Example:
Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is in use. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++ 1 file changed, 6 insertions(+)