| Message ID | 20190928142905.34832-1-wenyang@linux.alibaba.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | can: dev: add missing of_node_put after calling of_get_child_by_name | expand |
On 9/28/19 4:29 PM, Wen Yang wrote: > of_node_put needs to be called when the device node which is got > from of_get_child_by_name finished using. > > fixes: 2290aefa2e90 ("can: dev: Add support for limiting configured bitrate") > Signed-off-by: Wen Yang <wenyang@linux.alibaba.com> > Cc: Wolfgang Grandegger <wg@grandegger.com> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Franklin S Cooper Jr <fcooper@ti.com> > Cc: linux-can@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied to linux-can. Tnx, Marc
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index ac86be5..1c88c36 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -848,6 +848,7 @@ void of_can_transceiver(struct net_device *dev) return; ret = of_property_read_u32(dn, "max-bitrate", &priv->bitrate_max); + of_node_put(dn); if ((ret && ret != -EINVAL) || (!ret && !priv->bitrate_max)) netdev_warn(dev, "Invalid value for transceiver max bitrate. Ignoring bitrate limit.\n"); }
of_node_put needs to be called when the device node which is got from of_get_child_by_name finished using. fixes: 2290aefa2e90 ("can: dev: Add support for limiting configured bitrate") Signed-off-by: Wen Yang <wenyang@linux.alibaba.com> Cc: Wolfgang Grandegger <wg@grandegger.com> Cc: Marc Kleine-Budde <mkl@pengutronix.de> Cc: "David S. Miller" <davem@davemloft.net> Cc: Franklin S Cooper Jr <fcooper@ti.com> Cc: linux-can@vger.kernel.org Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/can/dev.c | 1 + 1 file changed, 1 insertion(+)