diff mbox series

can: gs_usb: prevent memory leak

Message ID 20190920024445.28214-1-navid.emamdoost@gmail.com
State Awaiting Upstream
Delegated to: David Miller
Headers show
Series can: gs_usb: prevent memory leak | expand

Commit Message

Navid Emamdoost Sept. 20, 2019, 2:44 a.m. UTC 
In gs_can_open if usb_submit_urb fails the allocated urb should be
released.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
 drivers/net/can/usb/gs_usb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marc Kleine-Budde Oct. 1, 2019, 8:23 p.m. UTC | #1 
On 9/20/19 4:44 AM, Navid Emamdoost wrote:
> In gs_can_open if usb_submit_urb fails the allocated urb should be
> released.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
>  drivers/net/can/usb/gs_usb.c | 1 +
>  1 file changed, 1 insertion(+)

Added Fixes line and added stable@v.k.o on Cc.

Marc
diff mbox series

Patch

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index bd6eb9967630..2f74f6704c12 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -623,6 +623,7 @@  static int gs_can_open(struct net_device *netdev)
 					   rc);
 
 				usb_unanchor_urb(urb);
+				usb_free_urb(urb);
 				break;
 			}