diff mbox series

[v2] dimlib: make DIMLIB a hidden symbol

Message ID 20190924160259.10987-1-uwe@kleine-koenig.org
State Accepted
Delegated to: David Miller
Headers show
Series [v2] dimlib: make DIMLIB a hidden symbol | expand

Commit Message

Uwe Kleine-König Sept. 24, 2019, 4:02 p.m. UTC
According to Tal Gilboa the only benefit from DIM comes from a driver
that uses it. So it doesn't make sense to make this symbol user visible,
instead all drivers that use it should select it (as is already the case
AFAICT).

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
Hello David,

On Tue, Sep 24, 2019 at 04:45:28PM +0200, David Miller wrote:
> Since this doesn't apply due to the moderation typo being elsewhere, I'd
> really like you to fix up this submission to properly be against 'net'.

I thought it would be possible to git-apply my patch with the -3 option.
I even tested that, but obviously it only applies to my tree that has
the git object with the typo fixed. Sorry for the extra effort I'm
forcing on you. This patch applies to your public tree from just now.

Best regads
Uwe

 lib/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Randy Dunlap Sept. 26, 2019, 12:18 a.m. UTC | #1
On 9/24/19 9:02 AM, Uwe Kleine-König wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
> 
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
> Hello David,
> 
> On Tue, Sep 24, 2019 at 04:45:28PM +0200, David Miller wrote:
>> Since this doesn't apply due to the moderation typo being elsewhere, I'd
>> really like you to fix up this submission to properly be against 'net'.
> 
> I thought it would be possible to git-apply my patch with the -3 option.
> I even tested that, but obviously it only applies to my tree that has
> the git object with the typo fixed. Sorry for the extra effort I'm
> forcing on you. This patch applies to your public tree from just now.
> 
> Best regads
> Uwe
> 
>  lib/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 4e6b1c3e4c98..d7fc9eb33b9b 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -555,8 +555,7 @@ config SIGNATURE
>  	  Implementation is done using GnuPG MPI library
>  
>  config DIMLIB
> -	bool "DIM library"
> -	default y
> +	bool
>  	help
>  	  Dynamic Interrupt Moderation library.
>  	  Implements an algorithm for dynamically change CQ modertion values
>
David Miller Sept. 27, 2019, 7:51 a.m. UTC | #2
From: Uwe Kleine-König <uwe@kleine-koenig.org>
Date: Tue, 24 Sep 2019 18:02:59 +0200

> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
> 
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>

Applied.
diff mbox series

Patch

diff --git a/lib/Kconfig b/lib/Kconfig
index 4e6b1c3e4c98..d7fc9eb33b9b 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -555,8 +555,7 @@  config SIGNATURE
 	  Implementation is done using GnuPG MPI library
 
 config DIMLIB
-	bool "DIM library"
-	default y
+	bool
 	help
 	  Dynamic Interrupt Moderation library.
 	  Implements an algorithm for dynamically change CQ modertion values