| Message ID | f35fa5a51f52fc1ef17a0a9ecd470e2a6792b3f8.1568887745.git.joabreu@synopsys.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause | expand |
On Thu, 19 Sep 2019 12:09:49 +0200, Jose Abreu wrote: > The Flow Control selftest is also available with ASYM Pause. Lets add > this check to the test and fix eventual false positive failures. > > Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") > Signed-off-by: Jose Abreu <joabreu@synopsys.com> Hi Jose! Thanks for the patch it looks good, seems like you posted it from a slightly different email address than was used for signoff: From: Jose Abreu <Jose.Abreu@synopsys.com> vs Signed-off-by: Jose Abreu <joabreu@synopsys.com> Could you please fix and repost? Automation may get upset otherwise.
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Sep/22/2019, 22:56:42 (UTC+00:00) > On Thu, 19 Sep 2019 12:09:49 +0200, Jose Abreu wrote: > > The Flow Control selftest is also available with ASYM Pause. Lets add > > this check to the test and fix eventual false positive failures. > > > > Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") > > Signed-off-by: Jose Abreu <joabreu@synopsys.com> > > Hi Jose! > > Thanks for the patch it looks good, seems like you posted it from > a slightly different email address than was used for signoff: > > From: Jose Abreu <Jose.Abreu@synopsys.com> > vs > Signed-off-by: Jose Abreu <joabreu@synopsys.com> > > Could you please fix and repost? Automation may get upset otherwise. Yeah that's my external vs. internal email messing around. Any of them works though. I resent it using the external one. Can you please take a look ? --- Thanks, Jose Miguel Abreu
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c index c56e89e1ae56..4b4b03245f6e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c @@ -670,7 +670,7 @@ static int stmmac_test_flowctrl(struct stmmac_priv *priv) unsigned int pkt_count; int i, ret = 0; - if (!phydev || !phydev->pause) + if (!phydev || (!phydev->pause && !phydev->asym_pause)) return -EOPNOTSUPP; tpriv = kzalloc(sizeof(*tpriv), GFP_KERNEL);
The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu <joabreu@synopsys.com> --- Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> Cc: Alexandre Torgue <alexandre.torgue@st.com> Cc: Jose Abreu <joabreu@synopsys.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)