| Message ID | cover.1569015835.git.amit.kucheria@linaro.org |
|---|---|
| Headers | show |
| Series | thermal: qcom: tsens: Add interrupt support | expand |
Quoting Amit Kucheria (2019-09-20 14:52:24) > Register upper-lower interrupts for each of the two tsens controllers. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > 1 file changed, 32 insertions(+), 28 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 96c0a481f454..bb763b362c16 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -175,8 +175,8 @@ > > thermal-zones { > cpu0-thermal { > - polling-delay-passive = <250>; > - polling-delay = <1000>; > + polling-delay-passive = <0>; > + polling-delay = <0>; I thought the plan was to make this unnecessary to change?
On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > Register upper-lower interrupts for each of the two tsens controllers. > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > > 1 file changed, 32 insertions(+), 28 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > index 96c0a481f454..bb763b362c16 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > @@ -175,8 +175,8 @@ > > > > thermal-zones { > > cpu0-thermal { > > - polling-delay-passive = <250>; > > - polling-delay = <1000>; > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > I thought the plan was to make this unnecessary to change? IMO that change should be part of a different series to the thermal core. I've not actually started working on it yet (traveling for the next 10 days or so) but plan to do it. Regards, Amit
Quoting Amit Kucheria (2019-09-20 15:07:25) > On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > > Register upper-lower interrupts for each of the two tsens controllers. > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > > --- > > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > > > 1 file changed, 32 insertions(+), 28 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > index 96c0a481f454..bb763b362c16 100644 > > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > @@ -175,8 +175,8 @@ > > > > > > thermal-zones { > > > cpu0-thermal { > > > - polling-delay-passive = <250>; > > > - polling-delay = <1000>; > > > + polling-delay-passive = <0>; > > > + polling-delay = <0>; > > > > I thought the plan was to make this unnecessary to change? > > IMO that change should be part of a different series to the thermal > core. I've not actually started working on it yet (traveling for the > next 10 days or so) but plan to do it. > Ok so the plan is to change DT and then change it back? That sounds quite bad so please fix the thermal core to not care about this before applying these changes so that we don't churn DT.
On Fri, Sep 20, 2019 at 3:07 PM Amit Kucheria <amit.kucheria@linaro.org> wrote: > > On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > > Register upper-lower interrupts for each of the two tsens controllers. > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > > --- > > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > > > 1 file changed, 32 insertions(+), 28 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > index 96c0a481f454..bb763b362c16 100644 > > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > @@ -175,8 +175,8 @@ > > > > > > thermal-zones { > > > cpu0-thermal { > > > - polling-delay-passive = <250>; > > > - polling-delay = <1000>; > > > + polling-delay-passive = <0>; > > > + polling-delay = <0>; > > > > I thought the plan was to make this unnecessary to change? > > IMO that change should be part of a different series to the thermal > core. I've not actually started working on it yet (traveling for the > next 10 days or so) but plan to do it. In fact, I was thinking of making the entire property optional, so I started down the path of converting the thermal bindings to YAML but haven't finished the process yet.
On Fri, Sep 20, 2019 at 3:09 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Amit Kucheria (2019-09-20 15:07:25) > > On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > > > Register upper-lower interrupts for each of the two tsens controllers. > > > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > > > --- > > > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > > > > 1 file changed, 32 insertions(+), 28 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > > index 96c0a481f454..bb763b362c16 100644 > > > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > > > @@ -175,8 +175,8 @@ > > > > > > > > thermal-zones { > > > > cpu0-thermal { > > > > - polling-delay-passive = <250>; > > > > - polling-delay = <1000>; > > > > + polling-delay-passive = <0>; > > > > + polling-delay = <0>; > > > > > > I thought the plan was to make this unnecessary to change? > > > > IMO that change should be part of a different series to the thermal > > core. I've not actually started working on it yet (traveling for the > > next 10 days or so) but plan to do it. > > > > Ok so the plan is to change DT and then change it back? That sounds > quite bad so please fix the thermal core to not care about this before > applying these changes so that we don't churn DT. Hi Stephen, Our emails crossed paths. I think we could just make the property optional so that we can remove the property completely for drivers that support interrupts. Comments? That is a bigger change to the bindings and I don't want to hold the tsens interrupt support hostage to agreement on this. Regards, Amit
Quoting Amit Kucheria (2019-09-20 15:14:58) > On Fri, Sep 20, 2019 at 3:09 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > Ok so the plan is to change DT and then change it back? That sounds > > quite bad so please fix the thermal core to not care about this before > > applying these changes so that we don't churn DT. > > Hi Stephen, > > Our emails crossed paths. I think we could just make the property > optional so that we can remove the property completely for drivers > that support interrupts. Comments? OK. This means that the delay properties become irrelevant once an interrupt is there? I guess that's OK. My concern is that we need to choose one or the other when it would be simpler to have both and fallback to the delays so that DT migration strategies are purely additive. It's not like the delays aren't calculated to be those numbers anymore. They're just not going to be used. > > That is a bigger change to the bindings and I don't want to hold the > tsens interrupt support hostage to agreement on this. Alright. I admit I haven't looked into the details but is it hard for some reason to make it use interrupts before delays?
Changes since v3: - Fix up the YAML definitions based on Rob's review Changes since v2: - Addressed Stephen's review comment - Moved the dt-bindings to yaml (This throws up some new warnings in various QCOM devicetrees. I'll send out a separate series to fix them up) - Collected reviews and acks - Added the dt-bindings to MAINTAINERS Changes since v1: - Collected reviews and acks - Addressed Stephen's review comments (hopefully I got them all). - Completely removed critical interrupt infrastructure from this series. Will post that separately. - Fixed a bug in sign-extension of temperature. - Fixed DT bindings to use the name of the interrupt e.g. "uplow" and use platform_get_irq_byname(). Add interrupt support to TSENS. The first 6 patches are general fixes and cleanups to the driver before interrupt support is introduced. This series has been developed against qcs404 and sdm845 and then tested on msm8916 and msm8974 (Thanks Brian). Testing on msm8998 would be appreciated since I don't have hardware handy. Amit Kucheria (15): drivers: thermal: tsens: Get rid of id field in tsens_sensor drivers: thermal: tsens: Simplify code flow in tsens_probe drivers: thermal: tsens: Add __func__ identifier to debug statements drivers: thermal: tsens: Add debugfs support arm: dts: msm8974: thermal: Add thermal zones for each sensor arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors dt-bindings: thermal: tsens: Convert over to a yaml schema arm64: dts: sdm845: thermal: Add interrupt support arm64: dts: msm8996: thermal: Add interrupt support arm64: dts: msm8998: thermal: Add interrupt support arm64: dts: qcs404: thermal: Add interrupt support arm: dts: msm8974: thermal: Add interrupt support arm64: dts: msm8916: thermal: Add interrupt support drivers: thermal: tsens: Create function to return sign-extended temperature drivers: thermal: tsens: Add interrupt support .../bindings/thermal/qcom-tsens.txt | 55 -- .../bindings/thermal/qcom-tsens.yaml | 168 ++++++ MAINTAINERS | 1 + arch/arm/boot/dts/qcom-msm8974.dtsi | 108 +++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 +- arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 +-- arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +-- drivers/thermal/qcom/tsens-8960.c | 4 +- drivers/thermal/qcom/tsens-common.c | 529 ++++++++++++++++-- drivers/thermal/qcom/tsens-v0_1.c | 11 + drivers/thermal/qcom/tsens-v1.c | 29 + drivers/thermal/qcom/tsens-v2.c | 13 + drivers/thermal/qcom/tsens.c | 58 +- drivers/thermal/qcom/tsens.h | 286 ++++++++-- 16 files changed, 1248 insertions(+), 312 deletions(-) delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.txt create mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml