mbox series

[0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()

Message ID 98fee5f4-1e45-a0c6-2a38-9201b201c6eb@web.de
Headers show
Series net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe() | expand

Message

Markus Elfring Sept. 20, 2019, 2:25 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 16:17:18 +0200

Two update suggestions were taken into account
from static source code analysis.


Markus Elfring (2):
  Use devm_platform_ioremap_resource()
  Return an error code as a constant

 drivers/net/dsa/vitesse-vsc73xx-platform.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

--
2.23.0

Comments

Andrew Lunn Sept. 20, 2019, 3:09 p.m. UTC | #1 
On Fri, Sep 20, 2019 at 04:25:53PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 16:17:18 +0200
> 
> Two update suggestions were taken into account
> from static source code analysis.

Hi Markus

netdev is closed at the moment for patch. Please repost once it
reopens, in about 2 weeks time.

	 Thanks
		Andrew
Markus Elfring Sept. 20, 2019, 3:30 p.m. UTC | #2 
> netdev is closed at the moment for patch.

I wonder about this information.


> Please repost once it reopens, in about 2 weeks time.

I hope that the presented change possibilities can be integrated
in the near future also without a repetition of this small patch series.
https://lore.kernel.org/patchwork/project/lkml/list/?series=411271

Regards,
Markus
Florian Fainelli Sept. 20, 2019, 4:36 p.m. UTC | #3 
On 9/20/19 8:30 AM, Markus Elfring wrote:
>> netdev is closed at the moment for patch.
> 
> I wonder about this information.

This is covered here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n40

and you can skip the reading and check this URL:

http://vger.kernel.org/~davem/net-next.html

> 
> 
>> Please repost once it reopens, in about 2 weeks time.
> 
> I hope that the presented change possibilities can be integrated
> in the near future also without a repetition of this small patch series.
> https://lore.kernel.org/patchwork/project/lkml/list/?series=411271

You will have to resend it, and unless a bug fix comes in, which would
be the only reason for your changes not to be "current" anymore, then it
should apply as-is and you should be fine.
Jakub Kicinski Sept. 20, 2019, 10:12 p.m. UTC | #4 
On Fri, 20 Sep 2019 09:36:57 -0700, Florian Fainelli wrote:
> On 9/20/19 8:30 AM, Markus Elfring wrote:
> >> netdev is closed at the moment for patch.  
> > 
> > I wonder about this information.  
> 
> This is covered here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n40
> 
> and you can skip the reading and check this URL:
> 
> http://vger.kernel.org/~davem/net-next.html

Indeed, looks like we have a mix of clean ups of varying clarity here.
I will just drop all, including the devm_platform_ioremap_resource()
conversion patches from patchwork for now. 

Markus, please repost them all once net-next opens. 
Sorry for inconvenience.
Markus Elfring Sept. 21, 2019, 7:12 a.m. UTC | #5 
> Indeed, looks like we have a mix of clean ups of varying clarity here.
> I will just drop all, including the devm_platform_ioremap_resource()
> conversion patches from patchwork for now.

I would prefer an other patch management in this case.


> Markus, please repost them all once net-next opens.
> Sorry for inconvenience.

I would find it nicer if presented change possibilities can be
automatically reconsidered on demand after each closed period.
https://patchwork.ozlabs.org/project/netdev/list/?submitter=76334&state=*
https://patchwork.ozlabs.org/project/netdev/list/?submitter=65077&state=*&archive=both

Regards,
Markus