Message ID | 1567687387-12993-5-git-send-email-tariqt@mellanox.com |
---|---|
State | Changes Requested |
Delegated to: | stephen hemminger |
Headers | show |
Series | Devlink health FMSG fixes and enhancements | expand |
On Thu, 5 Sep 2019 15:43:07 +0300 Tariq Toukan <tariqt@mellanox.com> wrote: > From: Aya Levin <ayal@mellanox.com> > > Prior to this patch both the reporter's name and the grace period > attributes shared the same bit. This caused zeroing grace period when > setting auto recovery. Let each parameter has its own bit. > > Fixes: b18d89195b16 ("devlink: Add devlink health set command") > Signed-off-by: Aya Levin <ayal@mellanox.com> > Acked-by: Jiri Pirko <jiri@mellanox.com> > Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Does not apply to current iproute2.
On 9/17/2019 6:23 PM, Stephen Hemminger wrote: > On Thu, 5 Sep 2019 15:43:07 +0300 > Tariq Toukan <tariqt@mellanox.com> wrote: > >> From: Aya Levin <ayal@mellanox.com> >> >> Prior to this patch both the reporter's name and the grace period >> attributes shared the same bit. This caused zeroing grace period when >> setting auto recovery. Let each parameter has its own bit. >> >> Fixes: b18d89195b16 ("devlink: Add devlink health set command") >> Signed-off-by: Aya Levin <ayal@mellanox.com> >> Acked-by: Jiri Pirko <jiri@mellanox.com> >> Signed-off-by: Tariq Toukan <tariqt@mellanox.com> > > Does not apply to current iproute2. This patch is redundant due to patch from Andrea Claudi 4fb98f08956ff4810354d75afa9b04cb6f8011bc Please reject it. Other patches that were submitted with, are valid. >
diff --git a/devlink/devlink.c b/devlink/devlink.c index 722b6a101673..306abfb5222b 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -231,11 +231,11 @@ static void ifname_map_free(struct ifname_map *ifname_map) #define DL_OPT_FLASH_FILE_NAME BIT(25) #define DL_OPT_FLASH_COMPONENT BIT(26) #define DL_OPT_HEALTH_REPORTER_NAME BIT(27) -#define DL_OPT_HEALTH_REPORTER_GRACEFUL_PERIOD BIT(27) -#define DL_OPT_HEALTH_REPORTER_AUTO_RECOVER BIT(28) +#define DL_OPT_HEALTH_REPORTER_GRACEFUL_PERIOD BIT(28) #define DL_OPT_TRAP_NAME BIT(29) #define DL_OPT_TRAP_ACTION BIT(30) #define DL_OPT_TRAP_GROUP_NAME BIT(31) +#define DL_OPT_HEALTH_REPORTER_AUTO_RECOVER BIT(32) struct dl_opts { uint64_t present; /* flags of present items */