Message ID | BANLkTimWpmFj1gx=XvvoXFVxL9q927iWfw@mail.gmail.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
Le mercredi 18 mai 2011 à 16:36 +0200, Jacek Luczak a écrit : > --- > net/sctp/bind_addr.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c > index faf71d1..6150ac5 100644 > --- a/net/sctp/bind_addr.c > +++ b/net/sctp/bind_addr.c > @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr > *bp, __u16 port) > /* Dispose of the address list. */ I am afraid your mailer mangled the patch. You should have only one line : @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr *bp, __u16 port) Instead, there is a line wrap : @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr *bp, __u16 port) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2011/5/18 Eric Dumazet <eric.dumazet@gmail.com>: > Le mercredi 18 mai 2011 à 16:36 +0200, Jacek Luczak a écrit : > >> --- >> net/sctp/bind_addr.c | 10 ++++------ >> 1 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c >> index faf71d1..6150ac5 100644 >> --- a/net/sctp/bind_addr.c >> +++ b/net/sctp/bind_addr.c >> @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr >> *bp, __u16 port) >> /* Dispose of the address list. */ > > I am afraid your mailer mangled the patch. > > You should have only one line : > > @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr *bp, __u16 port) > > Instead, there is a line wrap : > > @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr > *bp, __u16 port) > Sadly I'm completely aware of that. I don't have any such here that actually would not do this. Patch is attached to email just because of that. I can resend this in the evening from home. -Jacek -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jacek Luczak <difrost.kernel@gmail.com> Date: Wed, 18 May 2011 16:36:32 +0200 > @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr > *bp, __u16 port) As Eric stated, you need to fix your mailer to not corrupt your patch. GMAIL users can, and do, submit patches properly, unmangled. Heck, even Thunderbird users can it. Please follow the directions in Documentation/email-clients.txt to get your mailer in a state where it won't mangle your patch postings. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c index faf71d1..6150ac5 100644 --- a/net/sctp/bind_addr.c +++ b/net/sctp/bind_addr.c @@ -140,14 +140,12 @@ void sctp_bind_addr_init(struct sctp_bind_addr *bp, __u16 port) /* Dispose of the address list. */ static void sctp_bind_addr_clean(struct sctp_bind_addr *bp) { - struct sctp_sockaddr_entry *addr; - struct list_head *pos, *temp; + struct sctp_sockaddr_entry *addr, *temp; /* Empty the bind address list. */ - list_for_each_safe(pos, temp, &bp->address_list) { - addr = list_entry(pos, struct sctp_sockaddr_entry, list); - list_del(pos); - kfree(addr); + list_for_each_entry_safe(addr, temp, &bp->address_list, list) { + list_del_rcu(&addr->list); + call_rcu(&addr->rcu, sctp_local_addr_free); SCTP_DBG_OBJCNT_DEC(addr); }