| Message ID | 20190908160521.32185-1-stephen@that.guru |
|---|---|
| State | Accepted |
| Headers | show |
| Series | requirements: Switch to compatible releases | expand |
On Sun, 2019-09-08 at 17:05 +0100, Stephen Finucane wrote: > In commit ab0c443691, we switched from using commit ranges to fixed > ranges. This was a good idea in so far as it ensures we're providing an > application with dependencies that are guaranteed to work. However, > Patchwork as a project isn't active enough to warrant the continued busy > work effort necessary to keep bumping these versions and it's probably > about time to abandon the experiment. However, rather than switching > back to version ranges, use the compatible releases feature introduced > in PEP 440 [1]. This gives us most of the benefits of ranges but with a > nicer syntax. > > [1] https://www.python.org/dev/peps/pep-0440/#compatible-release > > Signed-off-by: Stephen Finucane <stephen@that.guru> > Cc: Daniel Axtens <dja@axtens.net> Passes everthing locally so I've gone ahead and merged this. Now to get openapi-core 0.9.0+ working. Stephen
diff --git a/requirements-dev.txt b/requirements-dev.txt index 35ead6f9..ee0e10b6 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -1,8 +1,8 @@ -Django==2.2.5; python_version >= '3.5' -Django==1.11.24; python_version < '3.0' # pyup: ignore -djangorestframework==3.9.2 -django-filter==2.1.0; python_version >= '3.5' -django-filter==1.1.0; python_version < '3.0' # pyup: ignore -django-debug-toolbar==1.11 -django-dbbackup==3.2.0 +Django~=2.2; python_version >= '3.5' +Django~=1.11; python_version < '3.0' # pyup: ignore +djangorestframework~=3.9 +django-filter~=2.1; python_version >= '3.5' +django-filter~=1.1; python_version < '3.0' # pyup: ignore +django-debug-toolbar~=1.11 +django-dbbackup~=3.2 -r requirements-test.txt diff --git a/requirements-prod.txt b/requirements-prod.txt index ba950f7a..92b44079 100644 --- a/requirements-prod.txt +++ b/requirements-prod.txt @@ -1,7 +1,7 @@ -Django==2.2.5; python_version >= '3.5' -Django==1.11.24; python_version < '3.0' # pyup: ignore -djangorestframework==3.9.2 -django-filter==2.1.0; python_version >= '3.5' -django-filter==1.1.0; python_version < '3.0' # pyup: ignore -psycopg2-binary==2.8.2 -sqlparse==0.3.0 +Django~=2.2; python_version >= '3.5' +Django~=1.11; python_version < '3.0' # pyup: ignore +djangorestframework~=3.9 +django-filter~=2.1; python_version >= '3.5' +django-filter~=1.1; python_version < '3.0' # pyup: ignore +psycopg2-binary~=2.8 +sqlparse~=0.3 diff --git a/requirements-test.txt b/requirements-test.txt index 0ad3c8aa..ace4ec13 100644 --- a/requirements-test.txt +++ b/requirements-test.txt @@ -1,5 +1,5 @@ -mysqlclient==1.3.14 -psycopg2-binary==2.8.2 -sqlparse==0.3.0 -python-dateutil==2.8.0 -openapi-core==0.8.0 +mysqlclient~=1.3.14 +psycopg2-binary~=2.8 +sqlparse~=0.3.0 +python-dateutil~=2.8 +openapi-core~=0.8
In commit ab0c443691, we switched from using commit ranges to fixed ranges. This was a good idea in so far as it ensures we're providing an application with dependencies that are guaranteed to work. However, Patchwork as a project isn't active enough to warrant the continued busy work effort necessary to keep bumping these versions and it's probably about time to abandon the experiment. However, rather than switching back to version ranges, use the compatible releases feature introduced in PEP 440 [1]. This gives us most of the benefits of ranges but with a nicer syntax. [1] https://www.python.org/dev/peps/pep-0440/#compatible-release Signed-off-by: Stephen Finucane <stephen@that.guru> Cc: Daniel Axtens <dja@axtens.net> --- requirements-dev.txt | 14 +++++++------- requirements-prod.txt | 14 +++++++------- requirements-test.txt | 10 +++++----- 3 files changed, 19 insertions(+), 19 deletions(-)