mbox series

[U-Boot,0/3] mmc: fsl_esdhc: clean up code

Message ID 20190819082750.22671-1-yangbo.lu@nxp.com
Headers show
Series mmc: fsl_esdhc: clean up code | expand

Message

Yangbo Lu Aug. 19, 2019, 8:27 a.m. UTC 
This patch-set is to clean up fsl_esdhc code.

Yangbo Lu (3):
  mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC
  mmc: fsl_esdhc: clean up code
  mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg

 drivers/mmc/fsl_esdhc.c | 371 +++++++++++++++++++-----------------------------
 include/fsl_esdhc.h     | 203 ++++++++++++--------------
 2 files changed, 240 insertions(+), 334 deletions(-)

Comments

Yangbo Lu Sept. 4, 2019, 4:22 a.m. UTC | #1 
Any comments?
Thanks:)

> -----Original Message-----
> From: Yangbo Lu <yangbo.lu@nxp.com>
> Sent: Monday, August 19, 2019 4:28 PM
> To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com>
> Cc: Y.b. Lu <yangbo.lu@nxp.com>
> Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> 
> This patch-set is to clean up fsl_esdhc code.
> 
> Yangbo Lu (3):
>   mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC
>   mmc: fsl_esdhc: clean up code
>   mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg
> 
>  drivers/mmc/fsl_esdhc.c | 371 +++++++++++++++++++-----------------------------
>  include/fsl_esdhc.h     | 203 ++++++++++++--------------
>  2 files changed, 240 insertions(+), 334 deletions(-)
> 
> --
> 2.7.4
Peng Fan Sept. 4, 2019, 7:52 a.m. UTC | #2 
> Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> 
> Any comments?

I'll pick up.

Regards,
Peng.

> Thanks:)
> 
> > -----Original Message-----
> > From: Yangbo Lu <yangbo.lu@nxp.com>
> > Sent: Monday, August 19, 2019 4:28 PM
> > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com>
> > Cc: Y.b. Lu <yangbo.lu@nxp.com>
> > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> >
> > This patch-set is to clean up fsl_esdhc code.
> >
> > Yangbo Lu (3):
> >   mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC
> >   mmc: fsl_esdhc: clean up code
> >   mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg
> >
> >  drivers/mmc/fsl_esdhc.c | 371
> +++++++++++++++++++-----------------------------
> >  include/fsl_esdhc.h     | 203 ++++++++++++--------------
> >  2 files changed, 240 insertions(+), 334 deletions(-)
> >
> > --
> > 2.7.4
Peng Fan Sept. 6, 2019, 2:12 a.m. UTC | #3 
> Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> 
> Any comments?

Patchset break build https://travis-ci.org/MrVan/u-boot/jobs/581073165

Please take a look.

Regards,
Peng.

> Thanks:)
> 
> > -----Original Message-----
> > From: Yangbo Lu <yangbo.lu@nxp.com>
> > Sent: Monday, August 19, 2019 4:28 PM
> > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com>
> > Cc: Y.b. Lu <yangbo.lu@nxp.com>
> > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> >
> > This patch-set is to clean up fsl_esdhc code.
> >
> > Yangbo Lu (3):
> >   mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC
> >   mmc: fsl_esdhc: clean up code
> >   mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg
> >
> >  drivers/mmc/fsl_esdhc.c | 371
> +++++++++++++++++++-----------------------------
> >  include/fsl_esdhc.h     | 203 ++++++++++++--------------
> >  2 files changed, 240 insertions(+), 334 deletions(-)
> >
> > --
> > 2.7.4
Yangbo Lu Sept. 6, 2019, 6:02 a.m. UTC | #4 
Hi Peng,

> -----Original Message-----
> From: Peng Fan
> Sent: Friday, September 6, 2019 10:12 AM
> To: Y.b. Lu <yangbo.lu@nxp.com>; u-boot@lists.denx.de
> Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> 
> > Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> >
> > Any comments?
> 
> Patchset break build https://travis-ci.org/MrVan/u-boot/jobs/581073165
> 
> Please take a look.

[Y.b. Lu] Sorry. I hadn't seen this issue with my toolchain. I have reproduced with buildman.
Let me send out v2 patch-set. The esdhc_ops declaration should be involved in non-DM conditional build.

Thanks.

> 
> Regards,
> Peng.
> 
> > Thanks:)
> >
> > > -----Original Message-----
> > > From: Yangbo Lu <yangbo.lu@nxp.com>
> > > Sent: Monday, August 19, 2019 4:28 PM
> > > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com>
> > > Cc: Y.b. Lu <yangbo.lu@nxp.com>
> > > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code
> > >
> > > This patch-set is to clean up fsl_esdhc code.
> > >
> > > Yangbo Lu (3):
> > >   mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC
> > >   mmc: fsl_esdhc: clean up code
> > >   mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg
> > >
> > >  drivers/mmc/fsl_esdhc.c | 371
> > +++++++++++++++++++-----------------------------
> > >  include/fsl_esdhc.h     | 203 ++++++++++++--------------
> > >  2 files changed, 240 insertions(+), 334 deletions(-)
> > >
> > > --
> > > 2.7.4