Message ID | 20190819082750.22671-1-yangbo.lu@nxp.com |
---|---|
Headers | show |
Series | mmc: fsl_esdhc: clean up code | expand |
Any comments? Thanks:) > -----Original Message----- > From: Yangbo Lu <yangbo.lu@nxp.com> > Sent: Monday, August 19, 2019 4:28 PM > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com> > Cc: Y.b. Lu <yangbo.lu@nxp.com> > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > This patch-set is to clean up fsl_esdhc code. > > Yangbo Lu (3): > mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC > mmc: fsl_esdhc: clean up code > mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg > > drivers/mmc/fsl_esdhc.c | 371 +++++++++++++++++++----------------------------- > include/fsl_esdhc.h | 203 ++++++++++++-------------- > 2 files changed, 240 insertions(+), 334 deletions(-) > > -- > 2.7.4
> Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > Any comments? I'll pick up. Regards, Peng. > Thanks:) > > > -----Original Message----- > > From: Yangbo Lu <yangbo.lu@nxp.com> > > Sent: Monday, August 19, 2019 4:28 PM > > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com> > > Cc: Y.b. Lu <yangbo.lu@nxp.com> > > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > > This patch-set is to clean up fsl_esdhc code. > > > > Yangbo Lu (3): > > mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC > > mmc: fsl_esdhc: clean up code > > mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg > > > > drivers/mmc/fsl_esdhc.c | 371 > +++++++++++++++++++----------------------------- > > include/fsl_esdhc.h | 203 ++++++++++++-------------- > > 2 files changed, 240 insertions(+), 334 deletions(-) > > > > -- > > 2.7.4
> Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > Any comments? Patchset break build https://travis-ci.org/MrVan/u-boot/jobs/581073165 Please take a look. Regards, Peng. > Thanks:) > > > -----Original Message----- > > From: Yangbo Lu <yangbo.lu@nxp.com> > > Sent: Monday, August 19, 2019 4:28 PM > > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com> > > Cc: Y.b. Lu <yangbo.lu@nxp.com> > > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > > This patch-set is to clean up fsl_esdhc code. > > > > Yangbo Lu (3): > > mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC > > mmc: fsl_esdhc: clean up code > > mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg > > > > drivers/mmc/fsl_esdhc.c | 371 > +++++++++++++++++++----------------------------- > > include/fsl_esdhc.h | 203 ++++++++++++-------------- > > 2 files changed, 240 insertions(+), 334 deletions(-) > > > > -- > > 2.7.4
Hi Peng, > -----Original Message----- > From: Peng Fan > Sent: Friday, September 6, 2019 10:12 AM > To: Y.b. Lu <yangbo.lu@nxp.com>; u-boot@lists.denx.de > Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > > Any comments? > > Patchset break build https://travis-ci.org/MrVan/u-boot/jobs/581073165 > > Please take a look. [Y.b. Lu] Sorry. I hadn't seen this issue with my toolchain. I have reproduced with buildman. Let me send out v2 patch-set. The esdhc_ops declaration should be involved in non-DM conditional build. Thanks. > > Regards, > Peng. > > > Thanks:) > > > > > -----Original Message----- > > > From: Yangbo Lu <yangbo.lu@nxp.com> > > > Sent: Monday, August 19, 2019 4:28 PM > > > To: u-boot@lists.denx.de; Peng Fan <peng.fan@nxp.com> > > > Cc: Y.b. Lu <yangbo.lu@nxp.com> > > > Subject: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > > > > This patch-set is to clean up fsl_esdhc code. > > > > > > Yangbo Lu (3): > > > mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC > > > mmc: fsl_esdhc: clean up code > > > mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg > > > > > > drivers/mmc/fsl_esdhc.c | 371 > > +++++++++++++++++++----------------------------- > > > include/fsl_esdhc.h | 203 ++++++++++++-------------- > > > 2 files changed, 240 insertions(+), 334 deletions(-) > > > > > > -- > > > 2.7.4