| Message ID | 20190830110732.8966-1-iii@linux.ibm.com |
|---|---|
| Headers | show |
| Series | selftests/bpf: fix endianness issues in test_sysctl | expand |
On 8/30/19 1:07 PM, Ilya Leoshkevich wrote: > Patch 1 is a preparatory commit, which introduces 64-bit endianness > conversion functions. > > Patch 2 fixes reading the wrong byte of an int. > > Patch 3 improves error reporting. > > Patch 4 uses the new conversion functions to fix wrong endianness of > immediates. > > v1->v2: Use bpf_ntohl and bpf_be64_to_cpu, drop __bpf_le64_to_cpu. > v2->v3: Split bpf_be64_to_cpu introduction into a separate patch. > Use the new functions in test_lwt_seg6local.c and > test_seg6_loop.c. > v3->v4: Improved commit message, split fixes that are not related to > each other into separate patches. > > Ilya Leoshkevich (4): > selftests/bpf: introduce bpf_cpu_to_be64 and bpf_be64_to_cpu > selftests/bpf: fix "ctx:write sysctl:write read ok" on s390 > selftests/bpf: improve unexpected success reporting in test_syctl > selftests/bpf: fix endianness issues in test_sysctl > > tools/testing/selftests/bpf/bpf_endian.h | 14 ++ > .../selftests/bpf/progs/test_lwt_seg6local.c | 16 +-- > .../selftests/bpf/progs/test_seg6_loop.c | 8 +- > tools/testing/selftests/bpf/test_sysctl.c | 130 ++++++++++++------ > 4 files changed, 107 insertions(+), 61 deletions(-) > Applied, thanks!
Patch 1 is a preparatory commit, which introduces 64-bit endianness conversion functions. Patch 2 fixes reading the wrong byte of an int. Patch 3 improves error reporting. Patch 4 uses the new conversion functions to fix wrong endianness of immediates. v1->v2: Use bpf_ntohl and bpf_be64_to_cpu, drop __bpf_le64_to_cpu. v2->v3: Split bpf_be64_to_cpu introduction into a separate patch. Use the new functions in test_lwt_seg6local.c and test_seg6_loop.c. v3->v4: Improved commit message, split fixes that are not related to each other into separate patches. Ilya Leoshkevich (4): selftests/bpf: introduce bpf_cpu_to_be64 and bpf_be64_to_cpu selftests/bpf: fix "ctx:write sysctl:write read ok" on s390 selftests/bpf: improve unexpected success reporting in test_syctl selftests/bpf: fix endianness issues in test_sysctl tools/testing/selftests/bpf/bpf_endian.h | 14 ++ .../selftests/bpf/progs/test_lwt_seg6local.c | 16 +-- .../selftests/bpf/progs/test_seg6_loop.c | 8 +- tools/testing/selftests/bpf/test_sysctl.c | 130 ++++++++++++------ 4 files changed, 107 insertions(+), 61 deletions(-)