| Message ID | cover.1566907161.git.amit.kucheria@linaro.org |
|---|---|
| Headers | show |
| Series | thermal: qcom: tsens: Add interrupt support | expand |
Quoting Amit Kucheria (2019-08-27 05:14:01) > msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal > zone for each of those sensors to expose the temperature of each zone. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > Tested-by: Brian Masney <masneyb@onstation.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Quoting Amit Kucheria (2019-08-27 05:14:02) > msm8916 uses sensors 0, 1, 2, 4 and 5. Sensor 3 is NOT used. Fixup the > device tree so that the correct sensor ID is used and as a result we can > actually check the temperature for the cpu2_3 sensor. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Quoting Amit Kucheria (2019-08-27 05:14:04) > Register upper-lower interrupts for each of the two tsens controllers. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Quoting Amit Kucheria (2019-08-27 05:14:05) > Register upper-lower interrupts for each of the two tsens controllers. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > 1 file changed, 32 insertions(+), 28 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 96c0a481f454e..bb763b362c162 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -175,8 +175,8 @@ > > thermal-zones { > cpu0-thermal { > - polling-delay-passive = <250>; > - polling-delay = <1000>; > + polling-delay-passive = <0>; > + polling-delay = <0>; Is it really necessary to change the configuration here to be 0 instead of some number? Why can't we detect that there's an interrupt and then ignore these properties?
On Wed, Aug 28, 2019 at 6:05 AM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Amit Kucheria (2019-08-27 05:14:05) > > Register upper-lower interrupts for each of the two tsens controllers. > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++------------- > > 1 file changed, 32 insertions(+), 28 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > index 96c0a481f454e..bb763b362c162 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > @@ -175,8 +175,8 @@ > > > > thermal-zones { > > cpu0-thermal { > > - polling-delay-passive = <250>; > > - polling-delay = <1000>; > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > Is it really necessary to change the configuration here to be 0 instead > of some number? Why can't we detect that there's an interrupt and then > ignore these properties? AFAICT, the thermal core currently depends on the passive and polling_delay being set to 0 to avoid setting dispatching polling work to a workqueue. If we leave the values to set, we'll continue to poll inspite of an interrupt. See thermal_core.c:thermal_zone_device_set_polling() But I agree, the core should detect the presence of an interrupt property and ignore the polling intervals. I'll see if I can fix this up later. Regards, Amit
Changes since v1: - Collected reviews and acks - Addressed Stephen's review comments (hopefully I got them all). - Completely removed critical interrupt infrastructure from this series. Will post that separately. - Fixed a bug in sign-extension of temperature. - Fixed DT bindings to use the name of the interrupt e.g. "uplow" and use platform_get_irq_byname(). Add interrupt support to TSENS. The first 6 patches are general fixes and cleanups to the driver before interrupt support is introduced. This series has been developed against qcs404 and sdm845 and then tested on msm8916 and msm8974 (Thanks Brian). Testing on msm8998 would be appreciated since I don't have hardware handy. Amit Kucheria (15): drivers: thermal: tsens: Get rid of id field in tsens_sensor drivers: thermal: tsens: Simplify code flow in tsens_probe drivers: thermal: tsens: Add __func__ identifier to debug statements drivers: thermal: tsens: Add debugfs support arm: dts: msm8974: thermal: Add thermal zones for each sensor arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors dt: thermal: tsens: Document interrupt support in tsens driver arm64: dts: sdm845: thermal: Add interrupt support arm64: dts: msm8996: thermal: Add interrupt support arm64: dts: msm8998: thermal: Add interrupt support arm64: dts: qcs404: thermal: Add interrupt support arm: dts: msm8974: thermal: Add interrupt support arm64: dts: msm8916: thermal: Add interrupt support drivers: thermal: tsens: Create function to return sign-extended temperature drivers: thermal: tsens: Add interrupt support .../bindings/thermal/qcom-tsens.txt | 8 + arch/arm/boot/dts/qcom-msm8974.dtsi | 108 +++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 +- arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 +-- arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +-- drivers/thermal/qcom/tsens-8960.c | 4 +- drivers/thermal/qcom/tsens-common.c | 528 ++++++++++++++++-- drivers/thermal/qcom/tsens-v0_1.c | 11 + drivers/thermal/qcom/tsens-v1.c | 29 + drivers/thermal/qcom/tsens-v2.c | 13 + drivers/thermal/qcom/tsens.c | 59 +- drivers/thermal/qcom/tsens.h | 288 ++++++++-- 14 files changed, 1089 insertions(+), 257 deletions(-)