| Message ID | 20190821015912.43151-1-yangbo.lu@nxp.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v4] ocelot_ace: fix action of trap | expand |
From: Yangbo Lu <yangbo.lu@nxp.com> Date: Wed, 21 Aug 2019 09:59:12 +0800 > The trap action should be copying the frame to CPU and > dropping it for forwarding, but current setting was just > copying frame to CPU. > > Fixes: b596229448dd ("net: mscc: ocelot: Add support for tcam") > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > Acked-by: Allan W. Nielsen <allan.nielsen@microchip.com> > --- > Changes for v4: > - Added ACK and Fixes info in commit message. > Changes for v3: > - Set MASK_MODE to 1 for dropping forwarding. > - Dropped other patches of patch-set. > Changes for v2: > - None. Applied.
diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c index 39aca1a..86fc6e6 100644 --- a/drivers/net/ethernet/mscc/ocelot_ace.c +++ b/drivers/net/ethernet/mscc/ocelot_ace.c @@ -317,7 +317,7 @@ static void is2_action_set(struct vcap_data *data, break; case OCELOT_ACL_ACTION_TRAP: VCAP_ACT_SET(PORT_MASK, 0x0); - VCAP_ACT_SET(MASK_MODE, 0x0); + VCAP_ACT_SET(MASK_MODE, 0x1); VCAP_ACT_SET(POLICE_ENA, 0x0); VCAP_ACT_SET(POLICE_IDX, 0x0); VCAP_ACT_SET(CPU_QU_NUM, 0x0);
The trap action should be copying the frame to CPU and dropping it for forwarding, but current setting was just copying frame to CPU. Fixes: b596229448dd ("net: mscc: ocelot: Add support for tcam") Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> Acked-by: Allan W. Nielsen <allan.nielsen@microchip.com> --- Changes for v4: - Added ACK and Fixes info in commit message. Changes for v3: - Set MASK_MODE to 1 for dropping forwarding. - Dropped other patches of patch-set. Changes for v2: - None. --- drivers/net/ethernet/mscc/ocelot_ace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)