| Message ID | 20190820141446.71604-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2,net-next] netdevsim: Fix build error without CONFIG_INET | expand |
On Tue, 20 Aug 2019 22:14:46 +0800, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Use ip_fast_csum instead of ip_send_check to avoid > dependencies on CONFIG_INET. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thank you! Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
On Tue, Aug 20, 2019 at 10:14:46PM +0800, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Use ip_fast_csum instead of ip_send_check to avoid > dependencies on CONFIG_INET. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Ido Schimmel <idosch@mellanox.com> Tested-by: Ido Schimmel <idosch@mellanox.com> Thanks for fixing this in my stead!
From: YueHaibing <yuehaibing@huawei.com> Date: Tue, 20 Aug 2019 22:14:46 +0800 > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Use ip_fast_csum instead of ip_send_check to avoid > dependencies on CONFIG_INET. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: use ip_fast_csum instead of ip_send_check Applied, thank you.
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c index c5b0261..39cdb6c 100644 --- a/drivers/net/netdevsim/dev.c +++ b/drivers/net/netdevsim/dev.c @@ -389,7 +389,8 @@ static struct sk_buff *nsim_dev_trap_skb_build(void) iph->ihl = 0x5; iph->tot_len = htons(tot_len); iph->ttl = 100; - ip_send_check(iph); + iph->check = 0; + iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl); udph = skb_put_zero(skb, sizeof(struct udphdr) + data_len); get_random_bytes(&udph->source, sizeof(u16));
If CONFIG_INET is not set, building fails: drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': dev.c:(.text+0x67b): undefined reference to `ip_send_check' Use ip_fast_csum instead of ip_send_check to avoid dependencies on CONFIG_INET. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: use ip_fast_csum instead of ip_send_check --- drivers/net/netdevsim/dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)