| Message ID | 20190814170501.1808-1-nikolay@cumulusnetworks.com |
|---|---|
| Headers | show |
| Series | net: bridge: mdb: allow dump/add/del of host-joined entries | expand |
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Date: Wed, 14 Aug 2019 20:04:57 +0300 > This set makes the bridge dump host-joined mdb entries, they should be > treated as normal entries since they take a slot and are aging out. ... Please respin with this warning fixed: net/bridge/br_mdb.c: In function ‘br_mdb_add’: net/bridge/br_mdb.c:725:4: warning: ‘p’ may be used uninitialized in this function [-Wmaybe-uninitialized] __br_mdb_notify(dev, p, entry, RTM_NEWMDB); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [davem@localhost net-next]$ gcc --version gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2) Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Hi, This set makes the bridge dump host-joined mdb entries, they should be treated as normal entries since they take a slot and are aging out. We already have notifications for them but we couldn't dump them until now so they remained hidden. We dump them similar to how they're notified, in order to keep user-space compatibility with the dumped objects (e.g. iproute2 dumps mdbs in a format which can be fed into add/del commands) we allow host-joined groups also to be added/deleted via mdb commands. That can later be used for L2 mcast MAC manipulation as was recently discussed. Note that iproute2 changes are not necessary, this set will work with the current user-space mdb code. Patch 01 - a trivial comment move Patch 02 - factors out the mdb filling code so it can be re-used for the host-joined entries Patch 03 - dumps host-joined entries Patch 04 - allows manipulation of host-joined entries via standard mdb calls v2: change patch 04 to avoid double notification and improve host group manual removal if no ports are present in the group Thanks, Nik Nikolay Aleksandrov (4): net: bridge: mdb: move vlan comments net: bridge: mdb: factor out mdb filling net: bridge: mdb: dump host-joined entries as well net: bridge: mdb: allow add/delete for host-joined groups net/bridge/br_mdb.c | 173 +++++++++++++++++++++++++------------- net/bridge/br_multicast.c | 30 +++++-- net/bridge/br_private.h | 2 + 3 files changed, 141 insertions(+), 64 deletions(-)