Message ID | 20190812181207.25287-1-unixmania@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | packages/devmem2: remove from all board configurations | expand |
On Mon, 12 Aug 2019 15:12:07 -0300 unixmania@gmail.com wrote: > From: Carlos Santos <unixmania@gmail.com> > > It is not used by any other application selected by those defconfigs. > > Tested building all boards and searching recursively for devmem2 in the > target directory. > > Signed-off-by: Carlos Santos <unixmania@gmail.com> > --- > CC: Ciro Santilli <ciro.santilli@gmail.com> > --- > Found while investigating https://bugs.busybox.net/show_bug.cgi?id=10171 Applied to master, thanks. Thomas
Hi Carlos, On Mon, Aug 12, 2019 at 03:12:07PM -0300, unixmania@gmail.com wrote: > > From: Carlos Santos <unixmania@gmail.com> > > It is not used by any other application selected by those defconfigs. > It's only here for debug purpose. Is the Busybox devmem version now enabled by default in order to have something in replacement? Regards Ludovic > Tested building all boards and searching recursively for devmem2 in the > target directory. > > Signed-off-by: Carlos Santos <unixmania@gmail.com> > --- > CC: Ciro Santilli <ciro.santilli@gmail.com> > --- > Found while investigating https://bugs.busybox.net/show_bug.cgi?id=10171 > > In the future we may decide to deprecate devmem2. > --- > configs/at91sam9x5ek_dev_defconfig | 1 - > configs/at91sam9x5ek_mmc_dev_defconfig | 1 - > configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig | 1 - > configs/atmel_sama5d2_xplained_mmc_dev_defconfig | 1 - > configs/atmel_sama5d3_xplained_dev_defconfig | 1 - > configs/atmel_sama5d3_xplained_mmc_dev_defconfig | 1 - > configs/atmel_sama5d4_xplained_dev_defconfig | 1 - > configs/atmel_sama5d4_xplained_mmc_dev_defconfig | 1 - > 8 files changed, 8 deletions(-) > > diff --git a/configs/at91sam9x5ek_dev_defconfig b/configs/at91sam9x5ek_dev_defconfig > index 7c29361e8a..4257dd5642 100644 > --- a/configs/at91sam9x5ek_dev_defconfig > +++ b/configs/at91sam9x5ek_dev_defconfig > @@ -47,7 +47,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > diff --git a/configs/at91sam9x5ek_mmc_dev_defconfig b/configs/at91sam9x5ek_mmc_dev_defconfig > index a085a48c4e..2e12038544 100644 > --- a/configs/at91sam9x5ek_mmc_dev_defconfig > +++ b/configs/at91sam9x5ek_mmc_dev_defconfig > @@ -50,7 +50,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > diff --git a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig > index da4a0fa155..7709e1e6a1 100644 > --- a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig > +++ b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig > @@ -39,7 +39,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_RNG_TOOLS=y > diff --git a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig > index 36cd49c1e9..2272fcd6ff 100644 > --- a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig > +++ b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig > @@ -53,7 +53,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > diff --git a/configs/atmel_sama5d3_xplained_dev_defconfig b/configs/atmel_sama5d3_xplained_dev_defconfig > index 2a1a722960..feac379701 100644 > --- a/configs/atmel_sama5d3_xplained_dev_defconfig > +++ b/configs/atmel_sama5d3_xplained_dev_defconfig > @@ -49,7 +49,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > diff --git a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig > index e455702b33..6733288eff 100644 > --- a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig > +++ b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig > @@ -52,7 +52,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > diff --git a/configs/atmel_sama5d4_xplained_dev_defconfig b/configs/atmel_sama5d4_xplained_dev_defconfig > index 2f05628a2d..4aaf767412 100644 > --- a/configs/atmel_sama5d4_xplained_dev_defconfig > +++ b/configs/atmel_sama5d4_xplained_dev_defconfig > @@ -50,7 +50,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > diff --git a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig > index 2ae1999c45..828085c7b5 100644 > --- a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig > +++ b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig > @@ -53,7 +53,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y > BR2_PACKAGE_MMC_UTILS=y > BR2_PACKAGE_MTD=y > BR2_PACKAGE_WILC1000_FIRMWARE=y > -BR2_PACKAGE_DEVMEM2=y > BR2_PACKAGE_EVTEST=y > BR2_PACKAGE_I2C_TOOLS=y > BR2_PACKAGE_SETSERIAL=y > -- > 2.18.1 > >
>>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@microchip.com> writes: > Hi Carlos, > On Mon, Aug 12, 2019 at 03:12:07PM -0300, unixmania@gmail.com wrote: >> >> From: Carlos Santos <unixmania@gmail.com> >> >> It is not used by any other application selected by those defconfigs. >> > It's only here for debug purpose. Is the Busybox devmem version now > enabled by default in order to have something in replacement? Yes it is: grep DEVMEM package/busybox/busybox.config CONFIG_DEVMEM=y
On Tue, Aug 13, 2019 at 09:13:27AM +0200, Peter Korsgaard wrote: > > >>>>> "Ludovic" == Ludovic Desroches <ludovic.desroches@microchip.com> writes: > > > Hi Carlos, > > On Mon, Aug 12, 2019 at 03:12:07PM -0300, unixmania@gmail.com wrote: > >> > >> From: Carlos Santos <unixmania@gmail.com> > >> > >> It is not used by any other application selected by those defconfigs. > >> > > > It's only here for debug purpose. Is the Busybox devmem version now > > enabled by default in order to have something in replacement? > > Yes it is: > > grep DEVMEM package/busybox/busybox.config > CONFIG_DEVMEM=y Ok, great. Thx Ludovic > > -- > Bye, Peter Korsgaard > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
diff --git a/configs/at91sam9x5ek_dev_defconfig b/configs/at91sam9x5ek_dev_defconfig index 7c29361e8a..4257dd5642 100644 --- a/configs/at91sam9x5ek_dev_defconfig +++ b/configs/at91sam9x5ek_dev_defconfig @@ -47,7 +47,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y diff --git a/configs/at91sam9x5ek_mmc_dev_defconfig b/configs/at91sam9x5ek_mmc_dev_defconfig index a085a48c4e..2e12038544 100644 --- a/configs/at91sam9x5ek_mmc_dev_defconfig +++ b/configs/at91sam9x5ek_mmc_dev_defconfig @@ -50,7 +50,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y diff --git a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig index da4a0fa155..7709e1e6a1 100644 --- a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig +++ b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig @@ -39,7 +39,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_RNG_TOOLS=y diff --git a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig index 36cd49c1e9..2272fcd6ff 100644 --- a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig +++ b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig @@ -53,7 +53,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y diff --git a/configs/atmel_sama5d3_xplained_dev_defconfig b/configs/atmel_sama5d3_xplained_dev_defconfig index 2a1a722960..feac379701 100644 --- a/configs/atmel_sama5d3_xplained_dev_defconfig +++ b/configs/atmel_sama5d3_xplained_dev_defconfig @@ -49,7 +49,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y diff --git a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig index e455702b33..6733288eff 100644 --- a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig +++ b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig @@ -52,7 +52,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y diff --git a/configs/atmel_sama5d4_xplained_dev_defconfig b/configs/atmel_sama5d4_xplained_dev_defconfig index 2f05628a2d..4aaf767412 100644 --- a/configs/atmel_sama5d4_xplained_dev_defconfig +++ b/configs/atmel_sama5d4_xplained_dev_defconfig @@ -50,7 +50,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y diff --git a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig index 2ae1999c45..828085c7b5 100644 --- a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig +++ b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig @@ -53,7 +53,6 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y BR2_PACKAGE_MMC_UTILS=y BR2_PACKAGE_MTD=y BR2_PACKAGE_WILC1000_FIRMWARE=y -BR2_PACKAGE_DEVMEM2=y BR2_PACKAGE_EVTEST=y BR2_PACKAGE_I2C_TOOLS=y BR2_PACKAGE_SETSERIAL=y