| Message ID | 20190809014923.69328-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2,net-next] taprio: remove unused variable 'entry_list_policy' | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Fri, 9 Aug 2019 09:49:23 +0800 > net/sched/sch_taprio.c:680:32: warning: > entry_list_policy defined but not used [-Wunused-const-variable=] > > One of the points of commit a3d43c0d56f1 ("taprio: Add support adding > an admin schedule") is that it removes support (it now returns "not > supported") for schedules using the TCA_TAPRIO_ATTR_SCHED_SINGLE_ENTRY > attribute (which were never used), the parsing of those types of schedules > was the only user of this policy. So removing this policy should be fine. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: respin commit log using Vinicius's explanation. Applied.
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index c39db50..046fd2c 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -677,10 +677,6 @@ static const struct nla_policy entry_policy[TCA_TAPRIO_SCHED_ENTRY_MAX + 1] = { [TCA_TAPRIO_SCHED_ENTRY_INTERVAL] = { .type = NLA_U32 }, }; -static const struct nla_policy entry_list_policy[TCA_TAPRIO_SCHED_MAX + 1] = { - [TCA_TAPRIO_SCHED_ENTRY] = { .type = NLA_NESTED }, -}; - static const struct nla_policy taprio_policy[TCA_TAPRIO_ATTR_MAX + 1] = { [TCA_TAPRIO_ATTR_PRIOMAP] = { .len = sizeof(struct tc_mqprio_qopt)
net/sched/sch_taprio.c:680:32: warning: entry_list_policy defined but not used [-Wunused-const-variable=] One of the points of commit a3d43c0d56f1 ("taprio: Add support adding an admin schedule") is that it removes support (it now returns "not supported") for schedules using the TCA_TAPRIO_ATTR_SCHED_SINGLE_ENTRY attribute (which were never used), the parsing of those types of schedules was the only user of this policy. So removing this policy should be fine. Reported-by: Hulk Robot <hulkci@huawei.com> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: respin commit log using Vinicius's explanation. --- net/sched/sch_taprio.c | 4 ---- 1 file changed, 4 deletions(-)