| Message ID | 20190808142623.69188-1-yuehaibing@huawei.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] taprio: remove unused variable 'entry_list_policy' | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Thu, 8 Aug 2019 22:26:23 +0800 > net/sched/sch_taprio.c:680:32: warning: > entry_list_policy defined but not used [-Wunused-const-variable=] > > It is not used since commit a3d43c0d56f1 ("taprio: Add > support adding an admin schedule") > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> This is probably unintentional and a bug, we should be using that policy value to validate that the sched list is indeed a nested attribute. I'm not applying this without at least a better and clear commit message explaining why we shouldn't be using this policy any more.
Hi, David Miller <davem@davemloft.net> writes: > From: YueHaibing <yuehaibing@huawei.com> > Date: Thu, 8 Aug 2019 22:26:23 +0800 > >> net/sched/sch_taprio.c:680:32: warning: >> entry_list_policy defined but not used [-Wunused-const-variable=] >> >> It is not used since commit a3d43c0d56f1 ("taprio: Add >> support adding an admin schedule") >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > This is probably unintentional and a bug, we should be using that > policy value to validate that the sched list is indeed a nested > attribute. Removing this policy should be fine. One of the points of commit (as explained in the commit message) a3d43c0d56f1 ("taprio: Add support adding an admin schedule") is that it removes support (it now returns "not supported") for schedules using the TCA_TAPRIO_ATTR_SCHED_SINGLE_ENTRY attribute (which were never used), the parsing of those types of schedules was the only user of this policy. > > I'm not applying this without at least a better and clear commit > message explaining why we shouldn't be using this policy any more. YueHaibing may use the text above in the commit message of a new spin of this patch if you think it's clear enough. Cheers, -- Vinicius
On 2019/8/9 4:42, Vinicius Costa Gomes wrote: > Hi, > > David Miller <davem@davemloft.net> writes: > >> From: YueHaibing <yuehaibing@huawei.com> >> Date: Thu, 8 Aug 2019 22:26:23 +0800 >> >>> net/sched/sch_taprio.c:680:32: warning: >>> entry_list_policy defined but not used [-Wunused-const-variable=] >>> >>> It is not used since commit a3d43c0d56f1 ("taprio: Add >>> support adding an admin schedule") >>> >>> Reported-by: Hulk Robot <hulkci@huawei.com> >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> >> This is probably unintentional and a bug, we should be using that >> policy value to validate that the sched list is indeed a nested >> attribute. > > Removing this policy should be fine. > > One of the points of commit (as explained in the commit message) > a3d43c0d56f1 ("taprio: Add support adding an admin schedule") is that it > removes support (it now returns "not supported") for schedules using the > TCA_TAPRIO_ATTR_SCHED_SINGLE_ENTRY attribute (which were never used), > the parsing of those types of schedules was the only user of this > policy. > >> >> I'm not applying this without at least a better and clear commit >> message explaining why we shouldn't be using this policy any more. > > YueHaibing may use the text above in the commit message of a new spin of > this patch if you think it's clear enough. Thanks, will send v2 with your explanation. > > > Cheers, > -- > Vinicius > > . >
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index c39db50..046fd2c 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -677,10 +677,6 @@ static const struct nla_policy entry_policy[TCA_TAPRIO_SCHED_ENTRY_MAX + 1] = { [TCA_TAPRIO_SCHED_ENTRY_INTERVAL] = { .type = NLA_U32 }, }; -static const struct nla_policy entry_list_policy[TCA_TAPRIO_SCHED_MAX + 1] = { - [TCA_TAPRIO_SCHED_ENTRY] = { .type = NLA_NESTED }, -}; - static const struct nla_policy taprio_policy[TCA_TAPRIO_ATTR_MAX + 1] = { [TCA_TAPRIO_ATTR_PRIOMAP] = { .len = sizeof(struct tc_mqprio_qopt)
net/sched/sch_taprio.c:680:32: warning: entry_list_policy defined but not used [-Wunused-const-variable=] It is not used since commit a3d43c0d56f1 ("taprio: Add support adding an admin schedule") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/sched/sch_taprio.c | 4 ---- 1 file changed, 4 deletions(-)