| Message ID | 20190723073928.22245-1-vicamo.yang@canonical.com |
|---|---|
| Headers | show |
| Series | drm/i915: Fix hotplug issues | expand |
On 7/23/19 12:39 AM, You-Sheng Yang wrote: > BugLink: http://bugs.launchpad.net/bugs/1835001 > > [Impact] > System does not always auto detect disconnection of external monitor on > Intel VGA. > > [Fix] > Two changes from drm-intel tree are necessary to introduce hotplug > retrying to fix this issue. They are: > > * drm/i915: Add support for retrying hotplug > * drm/i915: Enable hotplug retry > > [Test Case] > 1. open "system settings > display settings" > 2. connect laptop to an external HDMI monitor via HDMI port & cable > 3. unplug the HDMI cable > 4. check if "display settings" automatically detects the removal of the > external monitor > > [Regression potential] > Medium. For all the prerequisites they have been landed since 4.18, and > these two patches will only be merged some time later. Basically it > turns a currently existing kernel work to a delayed work so that it may > retry probing HDMI hotplug status. > > Imre Deak (1): > drm/i915: Add support for retrying hotplug > > José Roberto de Souza (1): > drm/i915: Enable hotplug retry > > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 3 +- > drivers/gpu/drm/i915/intel_ddi.c | 33 +++++++++++++--- > drivers/gpu/drm/i915/intel_dp.c | 19 ++++++--- > drivers/gpu/drm/i915/intel_drv.h | 16 ++++++-- > drivers/gpu/drm/i915/intel_hdmi.c | 28 ++++++++++++- > drivers/gpu/drm/i915/intel_hotplug.c | 59 ++++++++++++++++++++++------ > drivers/gpu/drm/i915/intel_sdvo.c | 8 ++-- > 8 files changed, 135 insertions(+), 33 deletions(-) > I think since these patches come from an upstream maintainer's tree, their commit subjects should have "(upstream)" in them [1]. Aside from that, with positive test results: Acked-by: Connor Kuehl <connor.kuehl@canonical.com> [1] https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat
On 23.07.19 09:39, You-Sheng Yang wrote: > BugLink: http://bugs.launchpad.net/bugs/1835001 > > [Impact] > System does not always auto detect disconnection of external monitor on > Intel VGA. > > [Fix] > Two changes from drm-intel tree are necessary to introduce hotplug > retrying to fix this issue. They are: > > * drm/i915: Add support for retrying hotplug > * drm/i915: Enable hotplug retry > > [Test Case] > 1. open "system settings > display settings" > 2. connect laptop to an external HDMI monitor via HDMI port & cable > 3. unplug the HDMI cable > 4. check if "display settings" automatically detects the removal of the > external monitor > > [Regression potential] > Medium. For all the prerequisites they have been landed since 4.18, and > these two patches will only be merged some time later. Basically it > turns a currently existing kernel work to a delayed work so that it may > retry probing HDMI hotplug status. > > Imre Deak (1): > drm/i915: Add support for retrying hotplug > > José Roberto de Souza (1): > drm/i915: Enable hotplug retry > > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 3 +- > drivers/gpu/drm/i915/intel_ddi.c | 33 +++++++++++++--- > drivers/gpu/drm/i915/intel_dp.c | 19 ++++++--- > drivers/gpu/drm/i915/intel_drv.h | 16 ++++++-- > drivers/gpu/drm/i915/intel_hdmi.c | 28 ++++++++++++- > drivers/gpu/drm/i915/intel_hotplug.c | 59 ++++++++++++++++++++++------ > drivers/gpu/drm/i915/intel_sdvo.c | 8 ++-- > 8 files changed, 135 insertions(+), 33 deletions(-) > Those are not upstream yet (though now in linux-next). The tag for neither upstream linux nor linux-next normally would be "UBUNTU: SAUCE: " but since they are already queued for -next we just need to ensure the SHA1 references are updated (if needed). Since this is a bigger change and by not being upstream likely did not receive as much testing as it could have, I would be ok with adding this to Disco but ignore the submission for Bionic for now. Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 2019-07-23 15:39:26 , You-Sheng Yang wrote: > BugLink: http://bugs.launchpad.net/bugs/1835001 > > [Impact] > System does not always auto detect disconnection of external monitor on > Intel VGA. > > [Fix] > Two changes from drm-intel tree are necessary to introduce hotplug > retrying to fix this issue. They are: > > * drm/i915: Add support for retrying hotplug > * drm/i915: Enable hotplug retry > > [Test Case] > 1. open "system settings > display settings" > 2. connect laptop to an external HDMI monitor via HDMI port & cable > 3. unplug the HDMI cable > 4. check if "display settings" automatically detects the removal of the > external monitor > > [Regression potential] > Medium. For all the prerequisites they have been landed since 4.18, and > these two patches will only be merged some time later. Basically it > turns a currently existing kernel work to a delayed work so that it may > retry probing HDMI hotplug status. > > Imre Deak (1): > drm/i915: Add support for retrying hotplug > > José Roberto de Souza (1): > drm/i915: Enable hotplug retry > > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 3 +- > drivers/gpu/drm/i915/intel_ddi.c | 33 +++++++++++++--- > drivers/gpu/drm/i915/intel_dp.c | 19 ++++++--- > drivers/gpu/drm/i915/intel_drv.h | 16 ++++++-- > drivers/gpu/drm/i915/intel_hdmi.c | 28 ++++++++++++- > drivers/gpu/drm/i915/intel_hotplug.c | 59 ++++++++++++++++++++++------ > drivers/gpu/drm/i915/intel_sdvo.c | 8 ++-- > 8 files changed, 135 insertions(+), 33 deletions(-) > > -- > 2.20.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team