diff mbox series

rtlwifi: remove unneeded function _rtl_dump_channel_map()

Message ID 20190724141020.58800-1-yuehaibing@huawei.com
State Awaiting Upstream
Delegated to: David Miller
Headers show
Series rtlwifi: remove unneeded function _rtl_dump_channel_map() | expand

Commit Message

Yue Haibing July 24, 2019, 2:10 p.m. UTC
Now _rtl_dump_channel_map() does not do any actual
thing using the channel. So remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/regd.c | 18 ------------------
 1 file changed, 18 deletions(-)

Comments

Ping-Ke Shih July 25, 2019, 2:50 a.m. UTC | #1
On Wed, 2019-07-24 at 22:10 +0800, YueHaibing wrote:
> Now _rtl_dump_channel_map() does not do any actual
> thing using the channel. So remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/regd.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c
> b/drivers/net/wireless/realtek/rtlwifi/regd.c
> index 6ccb5b9..c10432c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/regd.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/regd.c
> @@ -276,22 +276,6 @@ static void _rtl_reg_apply_world_flags(struct wiphy
> *wiphy,
>  	return;
>  }
>  
> -static void _rtl_dump_channel_map(struct wiphy *wiphy)
> -{
> -	enum nl80211_band band;
> -	struct ieee80211_supported_band *sband;
> -	struct ieee80211_channel *ch;
> -	unsigned int i;
> -
> -	for (band = 0; band < NUM_NL80211_BANDS; band++) {
> -		if (!wiphy->bands[band])
> -			continue;
> -		sband = wiphy->bands[band];
> -		for (i = 0; i < sband->n_channels; i++)
> -			ch = &sband->channels[i];
> -	}
> -}
> -
>  static int _rtl_reg_notifier_apply(struct wiphy *wiphy,
>  				   struct regulatory_request *request,
>  				   struct rtl_regulatory *reg)
> @@ -309,8 +293,6 @@ static int _rtl_reg_notifier_apply(struct wiphy *wiphy,
>  		break;
>  	}
>  
> -	_rtl_dump_channel_map(wiphy);
> -
>  	return 0;
>  }
>  

Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Kalle Valo Aug. 6, 2019, 12:34 p.m. UTC | #2
YueHaibing <yuehaibing@huawei.com> wrote:

> Now _rtl_dump_channel_map() does not do any actual
> thing using the channel. So remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

a4a68f727fb8 rtlwifi: remove unneeded function _rtl_dump_channel_map()
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c b/drivers/net/wireless/realtek/rtlwifi/regd.c
index 6ccb5b9..c10432c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/regd.c
+++ b/drivers/net/wireless/realtek/rtlwifi/regd.c
@@ -276,22 +276,6 @@  static void _rtl_reg_apply_world_flags(struct wiphy *wiphy,
 	return;
 }
 
-static void _rtl_dump_channel_map(struct wiphy *wiphy)
-{
-	enum nl80211_band band;
-	struct ieee80211_supported_band *sband;
-	struct ieee80211_channel *ch;
-	unsigned int i;
-
-	for (band = 0; band < NUM_NL80211_BANDS; band++) {
-		if (!wiphy->bands[band])
-			continue;
-		sband = wiphy->bands[band];
-		for (i = 0; i < sband->n_channels; i++)
-			ch = &sband->channels[i];
-	}
-}
-
 static int _rtl_reg_notifier_apply(struct wiphy *wiphy,
 				   struct regulatory_request *request,
 				   struct rtl_regulatory *reg)
@@ -309,8 +293,6 @@  static int _rtl_reg_notifier_apply(struct wiphy *wiphy,
 		break;
 	}
 
-	_rtl_dump_channel_map(wiphy);
-
 	return 0;
 }