Message ID | 20190728015549.27051-1-skalluru@marvell.com |
---|---|
Headers | show |
Series | qed*: Support for NVM config attributes. | expand |
From: Sudarsana Reddy Kalluru <skalluru@marvell.com> Date: Sat, 27 Jul 2019 18:55:47 -0700 > The patch series adds support for managing the NVM config attributes. > Patch (1) adds functionality to update config attributes via MFW. > Patch (2) adds driver interface for updating the config attributes. > > Changes from previous versions: > ------------------------------- > v3: Removed unused variable. > v2: Removed unused API. > > Please consider applying this series to "net-next". I don't see where an existing ethtool method hooks into and calls this new NVM code.
> -----Original Message----- > From: David Miller <davem@davemloft.net> > Sent: Sunday, July 28, 2019 7:43 AM > To: Sudarsana Reddy Kalluru <skalluru@marvell.com> > Cc: netdev@vger.kernel.org; Michal Kalderon <mkalderon@marvell.com>; > Ariel Elior <aelior@marvell.com> > Subject: Re: [PATCH net-next v3 0/2] qed*: Support for NVM config > attributes. > > From: Sudarsana Reddy Kalluru <skalluru@marvell.com> > Date: Sat, 27 Jul 2019 18:55:47 -0700 > > > The patch series adds support for managing the NVM config attributes. > > Patch (1) adds functionality to update config attributes via MFW. > > Patch (2) adds driver interface for updating the config attributes. > > > > Changes from previous versions: > > ------------------------------- > > v3: Removed unused variable. > > v2: Removed unused API. > > > > Please consider applying this series to "net-next". > > I don't see where an existing ethtool method hooks into and calls this new > NVM code. Dave, The new API/functionality is invoked as part of ethtool flash (ethtool -f) implementation. Example code path: ethtool_ops-->flash_device--> qede_flash_device() --> qed_nvm_flash() --> qed_nvm_flash_cfg_write() --> qed_mcp_nvm_set_cfg() Thanks, Sudarsana