| Message ID | 20190724130126.53532-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | qlge: Fix build error without CONFIG_ETHERNET | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Wed, 24 Jul 2019 21:01:26 +0800 > Now if CONFIG_ETHERNET is not set, QLGE driver > building fails: > > drivers/staging/qlge/qlge_main.o: In function `qlge_remove': > drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> I'll let Greg take this.
From: David Miller <davem@davemloft.net> Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT) > From: YueHaibing <yuehaibing@huawei.com> > Date: Wed, 24 Jul 2019 21:01:26 +0800 > >> Now if CONFIG_ETHERNET is not set, QLGE driver >> building fails: >> >> drivers/staging/qlge/qlge_main.o: In function `qlge_remove': >> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev' >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/") >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > I'll let Greg take this. Actually, I take that back. Since the move to staging happened in my tree I will take this ;-)
On Wed, Jul 24, 2019 at 02:12:28PM -0700, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT) > > > From: YueHaibing <yuehaibing@huawei.com> > > Date: Wed, 24 Jul 2019 21:01:26 +0800 > > > >> Now if CONFIG_ETHERNET is not set, QLGE driver > >> building fails: > >> > >> drivers/staging/qlge/qlge_main.o: In function `qlge_remove': > >> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev' > >> > >> Reported-by: Hulk Robot <hulkci@huawei.com> > >> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/") > >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > I'll let Greg take this. > > Actually, I take that back. > > Since the move to staging happened in my tree I will take this ;-) Thanks. If you want to push that "move" to Linus soon, I can then take any cleanup patches that show up for this driver, otherwise feel free to ignore them until 5.4-rc1. thanks, greg k-h
diff --git a/drivers/staging/qlge/Kconfig b/drivers/staging/qlge/Kconfig index ae9ed2c..a3cb25a3 100644 --- a/drivers/staging/qlge/Kconfig +++ b/drivers/staging/qlge/Kconfig @@ -2,7 +2,7 @@ config QLGE tristate "QLogic QLGE 10Gb Ethernet Driver Support" - depends on PCI + depends on ETHERNET && PCI help This driver supports QLogic ISP8XXX 10Gb Ethernet cards.
Now if CONFIG_ETHERNET is not set, QLGE driver building fails: drivers/staging/qlge/qlge_main.o: In function `qlge_remove': drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev' Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/staging/qlge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)