| Message ID | 20190715224841.6771-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: aspeed: Fix AST2500 example errors | expand |
On Tue, 16 Jul 2019, at 08:18, Rob Herring wrote: > The schema examples are now validated against the schema itself. The > AST2500 pinctrl schema has a couple of errors: > > Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.example.dt.yaml: \ > example-0: $nodename:0: 'example-0' does not match > '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.example.dt.yaml: \ > pinctrl: aspeed,external-nodes: [[1, 2]] is too short > > Fixes: 0a617de16730 ("dt-bindings: pinctrl: aspeed: Convert AST2500 > bindings to json-schema") > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Joel Stanley <joel@jms.id.au> > Cc: linux-aspeed@lists.ozlabs.org > Cc: linux-gpio@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Andrew Jeffery <andrew@aj.id.au> > --- > .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml > b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml > index a464cfa0cba3..3e6d85318577 100644 > --- > a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml > +++ > b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml > @@ -76,9 +76,6 @@ required: > > examples: > - | > - compatible = "simple-bus"; > - ranges; > - > apb { > compatible = "simple-bus"; > #address-cells = <1>; > @@ -91,7 +88,7 @@ examples: > > pinctrl: pinctrl { > compatible = "aspeed,g5-pinctrl"; > - aspeed,external-nodes = <&gfx &lhc>; > + aspeed,external-nodes = <&gfx>, <&lhc>; > > pinctrl_i2c3_default: i2c3_default { > function = "I2C3"; > -- > 2.20.1 > >
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml index a464cfa0cba3..3e6d85318577 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml @@ -76,9 +76,6 @@ required: examples: - | - compatible = "simple-bus"; - ranges; - apb { compatible = "simple-bus"; #address-cells = <1>; @@ -91,7 +88,7 @@ examples: pinctrl: pinctrl { compatible = "aspeed,g5-pinctrl"; - aspeed,external-nodes = <&gfx &lhc>; + aspeed,external-nodes = <&gfx>, <&lhc>; pinctrl_i2c3_default: i2c3_default { function = "I2C3";
The schema examples are now validated against the schema itself. The AST2500 pinctrl schema has a couple of errors: Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.example.dt.yaml: \ example-0: $nodename:0: 'example-0' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.example.dt.yaml: \ pinctrl: aspeed,external-nodes: [[1, 2]] is too short Fixes: 0a617de16730 ("dt-bindings: pinctrl: aspeed: Convert AST2500 bindings to json-schema") Cc: Andrew Jeffery <andrew@aj.id.au> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Joel Stanley <joel@jms.id.au> Cc: linux-aspeed@lists.ozlabs.org Cc: linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)