| Message ID | 20190714120225.15279-1-efremov@linux.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | gve: Remove the exporting of gve_probe | expand |
From: Denis Efremov <efremov@linux.com> Date: Sun, 14 Jul 2019 15:02:25 +0300 > The function gve_probe is declared static and marked EXPORT_SYMBOL, which > is at best an odd combination. Because the function is not used outside of > the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this > commit removes the EXPORT_SYMBOL() marking. > > Signed-off-by: Denis Efremov <efremov@linux.com> Applied, thanks.
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index 24f16e3368cd..e8ee8cac2bbf 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -1192,7 +1192,6 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent) pci_disable_device(pdev); return -ENXIO; } -EXPORT_SYMBOL(gve_probe); static void gve_remove(struct pci_dev *pdev) {
The function gve_probe is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking. Signed-off-by: Denis Efremov <efremov@linux.com> --- drivers/net/ethernet/google/gve/gve_main.c | 1 - 1 file changed, 1 deletion(-)