| Message ID | 20190712153336.5018-1-chunkeey@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: dsa: qca8k: replace legacy gpio include | expand |
On Fri, 12 Jul 2019 17:33:36 +0200, Christian Lamparter <chunkeey@gmail.com> wrote: > This patch replaces the legacy bulk gpio.h include > with the proper gpio/consumer.h variant. This was > caught by the kbuild test robot that was running > into an error because of this. > > For more information why linux/gpio.h is bad can be found in: > commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy") > > Reported-by: kbuild test robot <lkp@intel.com> > Link: https://www.spinics.net/lists/netdev/msg584447.html > Fixes: a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature") > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
On 7/12/19 8:33 AM, Christian Lamparter wrote: > This patch replaces the legacy bulk gpio.h include > with the proper gpio/consumer.h variant. This was > caught by the kbuild test robot that was running > into an error because of this. > > For more information why linux/gpio.h is bad can be found in: > commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy") > > Reported-by: kbuild test robot <lkp@intel.com> > Link: https://www.spinics.net/lists/netdev/msg584447.html > Fixes: a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature") > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
From: Christian Lamparter <chunkeey@gmail.com> Date: Fri, 12 Jul 2019 17:33:36 +0200 > This patch replaces the legacy bulk gpio.h include > with the proper gpio/consumer.h variant. This was > caught by the kbuild test robot that was running > into an error because of this. > > For more information why linux/gpio.h is bad can be found in: > commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy") > > Reported-by: kbuild test robot <lkp@intel.com> > Link: https://www.spinics.net/lists/netdev/msg584447.html > Fixes: a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature") > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Applied.
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 27709f866c23..232e8cc96f6d 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -14,7 +14,7 @@ #include <linux/of_platform.h> #include <linux/if_bridge.h> #include <linux/mdio.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/etherdevice.h> #include "qca8k.h"
This patch replaces the legacy bulk gpio.h include with the proper gpio/consumer.h variant. This was caught by the kbuild test robot that was running into an error because of this. For more information why linux/gpio.h is bad can be found in: commit 56a46b6144e7 ("gpio: Clarify that <linux/gpio.h> is legacy") Reported-by: kbuild test robot <lkp@intel.com> Link: https://www.spinics.net/lists/netdev/msg584447.html Fixes: a653f2f538f9 ("net: dsa: qca8k: introduce reset via gpio feature") Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)