| Message ID | 20190708144224.33376-1-yuehaibing@huawei.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: vsc73xx: Fix Kconfig warning and build errors | expand |
On Mon, Jul 08, 2019 at 10:42:24PM +0800, YueHaibing wrote: > Fix Kconfig dependency warning and subsequent build errors > caused by OF is not set: > > WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX > Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=n] && NET_DSA [=m] > Selected by [m]: > - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y] > > Move OF and NET_DSA dependencies to NET_DSA_VITESSE_VSC73XX/ > NET_DSA_VITESSE_VSC73XX_PLATFORM to fix this. Hi YueHaibing I might be better to make NET_DSA_VITESSE_VSC73XX_SPI and NET_DSA_VITESSE_VSC73XX_PLATFORM depend on NET_DSA_VITESSE_VSC73XX rather than select it. Andrew
diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index cf9dbd1..e28c209 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -100,8 +100,6 @@ config NET_DSA_SMSC_LAN9303_MDIO config NET_DSA_VITESSE_VSC73XX tristate - depends on OF - depends on NET_DSA select FIXED_PHY select VITESSE_PHY select GPIOLIB @@ -112,6 +110,7 @@ config NET_DSA_VITESSE_VSC73XX config NET_DSA_VITESSE_VSC73XX_SPI tristate "Vitesse VSC7385/7388/7395/7398 SPI mode support" depends on SPI + depends on OF && NET_DSA select NET_DSA_VITESSE_VSC73XX ---help--- This enables support for the Vitesse VSC7385, VSC7388, VSC7395 @@ -120,6 +119,7 @@ config NET_DSA_VITESSE_VSC73XX_SPI config NET_DSA_VITESSE_VSC73XX_PLATFORM tristate "Vitesse VSC7385/7388/7395/7398 Platform mode support" depends on HAS_IOMEM + depends on OF && NET_DSA select NET_DSA_VITESSE_VSC73XX ---help--- This enables support for the Vitesse VSC7385, VSC7388, VSC7395
Fix Kconfig dependency warning and subsequent build errors caused by OF is not set: WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=n] && NET_DSA [=m] Selected by [m]: - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y] Move OF and NET_DSA dependencies to NET_DSA_VITESSE_VSC73XX/ NET_DSA_VITESSE_VSC73XX_PLATFORM to fix this. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 631e83bf7c0e ("net: dsa: vsc73xx: add support for parallel mode") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/dsa/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)