Message ID | 1562500388-16847-2-git-send-email-tariqt@mellanox.com |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | mlx5e devlink health reporters | expand |
Sun, Jul 07, 2019 at 01:52:53PM CEST, tariqt@mellanox.com wrote: >From: Aya Levin <ayal@mellanox.com> > >This reverts commit 2e5b0534622fa87fd570d54af2d01ce304b88077. > >This commit was needed prior to commit f6b19b354d50 ("net: devlink: >select NET_DEVLINK from drivers") Then, reporter's pointer could have >been a NULL. But with NET_DEVLINK mandatory to MLX5_CORE in Kconfig, >pointer can only hold an error in bad path. > >Signed-off-by: Aya Levin <ayal@mellanox.com> >Signed-off-by: Tariq Toukan <tariqt@mellanox.com> I'm not sure if the patch name "Revert: ..." is correct. I would rather just describe the change and don't mention the "revert" even in the patch description. The patch looks good. Acked-by: Jiri Pirko <jiri@mellanox.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c index 476dd97f7f2f..24626bb55598 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c @@ -302,7 +302,7 @@ int mlx5e_tx_reporter_create(struct mlx5e_priv *priv) netdev_warn(priv->netdev, "Failed to create tx reporter, err = %ld\n", PTR_ERR(priv->tx_reporter)); - return IS_ERR_OR_NULL(priv->tx_reporter); + return PTR_ERR_OR_ZERO(priv->tx_reporter); } void mlx5e_tx_reporter_destroy(struct mlx5e_priv *priv)