| Message ID | 93898abe-9a7d-0c64-0856-094b62e07ba2@web.de |
|---|---|
| State | Rejected |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | bpf: Replace a seq_printf() call by seq_puts() in btf_enum_seq_show() | expand |
On 7/2/19 10:13 AM, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 2 Jul 2019 19:04:08 +0200 > > A string which did not contain a data format specification should be put > into a sequence. Thus use the corresponding function “seq_puts”. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Yonghong Song <yhs@fb.com> > --- > kernel/bpf/btf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c > index 546ebee39e2a..679a19968f29 100644 > --- a/kernel/bpf/btf.c > +++ b/kernel/bpf/btf.c > @@ -2426,9 +2426,8 @@ static void btf_enum_seq_show(const struct btf *btf, const struct btf_type *t, > > for (i = 0; i < nr_enums; i++) { > if (v == enums[i].val) { > - seq_printf(m, "%s", > - __btf_name_by_offset(btf, > - enums[i].name_off)); > + seq_puts(m, > + __btf_name_by_offset(btf, enums[i].name_off)); > return; > } > } > -- > 2.22.0 >
On 07/02/2019 07:13 PM, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 2 Jul 2019 19:04:08 +0200 > > A string which did not contain a data format specification should be put > into a sequence. Thus use the corresponding function “seq_puts”. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> The code is fine as is, I'm not applying this.
On Wed, Jul 03, 2019 at 12:09:51PM +0200, Daniel Borkmann wrote: > On 07/02/2019 07:13 PM, Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Tue, 2 Jul 2019 19:04:08 +0200 > > > > A string which did not contain a data format specification should be put > > into a sequence. Thus use the corresponding function “seq_puts”. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > The code is fine as is, I'm not applying this. Just a heads up, this person/bot is in my kill-file, making it easier to ignore crazy things like this. I recommend it for other maintainers to also do as well. thanks, greg k-h
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 546ebee39e2a..679a19968f29 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -2426,9 +2426,8 @@ static void btf_enum_seq_show(const struct btf *btf, const struct btf_type *t, for (i = 0; i < nr_enums; i++) { if (v == enums[i].val) { - seq_printf(m, "%s", - __btf_name_by_offset(btf, - enums[i].name_off)); + seq_puts(m, + __btf_name_by_offset(btf, enums[i].name_off)); return; } }