mbox series

[U-Boot,0/4] SiFive SPI MMC Support

Message ID 20190628083752.64346-1-anup.patel@wdc.com
Headers show
Series SiFive SPI MMC Support | expand

Message

Anup Patel June 28, 2019, 8:38 a.m. UTC 
This patchset adds:
1. SiFive SPI driver
2. New MMC SPI driver based on DM_MMC and DM_SPI
3. Enables SiFive SPI driver and MMC SPI driver for SiFive Unleashed board

With this patch series, we can now load files from SD card on SiFive
Unleashed board. Many thanks to Bhargav for porting SiFive SPI driver
and updating MMC SPI driver for us.

These patches can be also found in riscv_unleashed_mmc_spi_v1 branch of:
https//github.com/avpatel/u-boot.git

Anup Patel (1):
  mmc: skip select_mode_and_width for MMC SPI host

Bhargav Shah (3):
  spi: Add SiFive SPI driver
  mmc: mmc_spi: Re-write driver using DM framework
  riscv: sifive: fu540: Enable SiFive SPI and MMC SPI drivers

 board/sifive/fu540/Kconfig |   8 +
 drivers/mmc/Kconfig        |  18 ++
 drivers/mmc/mmc.c          |  14 ++
 drivers/mmc/mmc_spi.c      | 455 +++++++++++++++++++++++--------------
 drivers/spi/Kconfig        |   8 +
 drivers/spi/Makefile       |   1 +
 drivers/spi/spi-sifive.c   | 405 +++++++++++++++++++++++++++++++++
 7 files changed, 742 insertions(+), 167 deletions(-)
 create mode 100644 drivers/spi/spi-sifive.c

--
2.17.1

Comments

Atish Patra June 29, 2019, 12:31 a.m. UTC | #1 
On Fri, 2019-06-28 at 08:38 +0000, Anup Patel wrote:
> This patchset adds:
> 1. SiFive SPI driver
> 2. New MMC SPI driver based on DM_MMC and DM_SPI
> 3. Enables SiFive SPI driver and MMC SPI driver for SiFive Unleashed
> board
> 
> With this patch series, we can now load files from SD card on SiFive
> Unleashed board. Many thanks to Bhargav for porting SiFive SPI driver
> and updating MMC SPI driver for us.
> 
> These patches can be also found in riscv_unleashed_mmc_spi_v1 branch
> of:
> https//github.com/avpatel/u-boot.git
> 

Awesome.

You should update the README as well removing following lines.

-1. SPI host driver is still missing.
-2. SPI MMC driver does not compile and needs a re-write using U-Boot
DM.


> Anup Patel (1):
>   mmc: skip select_mode_and_width for MMC SPI host
> 
> Bhargav Shah (3):
>   spi: Add SiFive SPI driver
>   mmc: mmc_spi: Re-write driver using DM framework
>   riscv: sifive: fu540: Enable SiFive SPI and MMC SPI drivers
> 
>  board/sifive/fu540/Kconfig |   8 +
>  drivers/mmc/Kconfig        |  18 ++
>  drivers/mmc/mmc.c          |  14 ++
>  drivers/mmc/mmc_spi.c      | 455 +++++++++++++++++++++++----------
> ----
>  drivers/spi/Kconfig        |   8 +
>  drivers/spi/Makefile       |   1 +
>  drivers/spi/spi-sifive.c   | 405 +++++++++++++++++++++++++++++++++
>  7 files changed, 742 insertions(+), 167 deletions(-)
>  create mode 100644 drivers/spi/spi-sifive.c
> 
> --
> 2.17.1
Anup Patel June 29, 2019, 4:51 a.m. UTC | #2 
On Sat, Jun 29, 2019 at 6:01 AM Atish Patra <Atish.Patra@wdc.com> wrote:
>
> On Fri, 2019-06-28 at 08:38 +0000, Anup Patel wrote:
> > This patchset adds:
> > 1. SiFive SPI driver
> > 2. New MMC SPI driver based on DM_MMC and DM_SPI
> > 3. Enables SiFive SPI driver and MMC SPI driver for SiFive Unleashed
> > board
> >
> > With this patch series, we can now load files from SD card on SiFive
> > Unleashed board. Many thanks to Bhargav for porting SiFive SPI driver
> > and updating MMC SPI driver for us.
> >
> > These patches can be also found in riscv_unleashed_mmc_spi_v1 branch
> > of:
> > https//github.com/avpatel/u-boot.git
> >
>
> Awesome.
>
> You should update the README as well removing following lines.
>
> -1. SPI host driver is still missing.
> -2. SPI MMC driver does not compile and needs a re-write using U-Boot
> DM.

Good point. I will send v2 to have separate documentation update patch.

Regards,
Anup

>
>
> > Anup Patel (1):
> >   mmc: skip select_mode_and_width for MMC SPI host
> >
> > Bhargav Shah (3):
> >   spi: Add SiFive SPI driver
> >   mmc: mmc_spi: Re-write driver using DM framework
> >   riscv: sifive: fu540: Enable SiFive SPI and MMC SPI drivers
> >
> >  board/sifive/fu540/Kconfig |   8 +
> >  drivers/mmc/Kconfig        |  18 ++
> >  drivers/mmc/mmc.c          |  14 ++
> >  drivers/mmc/mmc_spi.c      | 455 +++++++++++++++++++++++----------
> > ----
> >  drivers/spi/Kconfig        |   8 +
> >  drivers/spi/Makefile       |   1 +
> >  drivers/spi/spi-sifive.c   | 405 +++++++++++++++++++++++++++++++++
> >  7 files changed, 742 insertions(+), 167 deletions(-)
> >  create mode 100644 drivers/spi/spi-sifive.c
> >
> > --
> > 2.17.1
> --
> Regards,
> Atish