Message ID | cover.e80da8845680a45c2e07d5f17280fdba84555b8a.1561649505.git-series.maxime.ripard@bootlin.com |
---|---|
Headers | show |
Series | net: Add generic and Allwinner YAML bindings | expand |
On Thu, Jun 27, 2019 at 05:31:55PM +0200, Maxime Ripard wrote: > The phy device tree property has been deprecated in favor of phy-handle, > let's replace it. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Maxime Ripard <maxime.ripard@bootlin.com> Date: Thu, 27 Jun 2019 17:31:42 +0200 > This is an attempt at getting the main generic DT bindings for the ethernet > (and related) devices, and convert some DT bindings for the Allwinner DTs > to YAML as well. > > This should provide some DT validation coverage. I don't think this should go via my tree as it's all DT stuff.
On Thu, Jun 27, 2019 at 11:22 AM David Miller <davem@davemloft.net> wrote: > > From: Maxime Ripard <maxime.ripard@bootlin.com> > Date: Thu, 27 Jun 2019 17:31:42 +0200 > > > This is an attempt at getting the main generic DT bindings for the ethernet > > (and related) devices, and convert some DT bindings for the Allwinner DTs > > to YAML as well. > > > > This should provide some DT validation coverage. > > I don't think this should go via my tree as it's all DT stuff. That's fine. I can take it. There's one conflict with commit 79b647a0c0d5 ("dt-bindings: net: document new usxgmii phy mode"), but that's easy enough to handle. Any other changes to the binding docs will need to go thru me this cycle. Rob
On Thu, Jun 27, 2019 at 11:32 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > The phy device tree property has been deprecated in favor of phy-handle, > let's replace it. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> This patch breaks Ethernet on all my dwmac-sunxi, i.e. old GMAC, boards, with the following error messages: sun7i-dwmac 1c50000.ethernet eth0: no phy at addr -1 sun7i-dwmac 1c50000.ethernet eth0: stmmac_open: Cannot attach to PHY (error: -19) Reverting this patch fixes it. It also breaks the A10/A10s, but that's probably because the sun4i-emac driver doesn't recognize the "phy-handle" property. ChenYu