mbox series

[v5,0/2] Add DSI panel driver for Raydium RM67191

Message ID 1561544420-15572-1-git-send-email-robert.chiras@nxp.com
Headers show
Series Add DSI panel driver for Raydium RM67191 | expand

Message

Robert Chiras June 26, 2019, 10:20 a.m. UTC 
This patch-set contains the DRM panel driver and dt-bindings documentation
for the DSI driven panel: Raydium RM67191.

v5:
- Removed unnecessary debug messages (fabio)
- Handled error case for gpio pin (fabio)

v4:
- Changed default_timing structure type from 'struct display_timing' to
  'struct drm_display_mode' (fabio)
- Replaced devm_gpiod_get with devm_gpiod_get_optional (fabio)
- Added power regulators (fabio)
- Removed pm_ops (fabio)

v3:
- Added myself to MAINTAINERS for this driver (sam)
- Removed display-timings property (fabio)
- Fixed dt description (sam)
- Re-arranged calls inside get_modes function (sam)
- Changed ifdefs with _maybe_unused for suspend/resume functions (sam)
- Collected Reviewed-by from Sam

v2:
- Fixed 'reset-gpio' to 'reset-gpios' property naming (fabio)
- Changed the state of the reset gpio to active low and fixed how it is
  handled in driver (fabio)
- Fixed copyright statement (daniel)
- Reordered includes (sam)
- Added defines for panel specific color formats (fabio)
- Removed unnecessary tests in enable and unprepare (sam)
- Removed the unnecessary backlight write in enable (sam)

Robert Chiras (2):
  dt-bindings: display: panel: Add support for Raydium RM67191 panel
  drm/panel: Add support for Raydium RM67191 panel driver

 .../bindings/display/panel/raydium,rm67191.txt     |  41 ++
 MAINTAINERS                                        |   6 +
 drivers/gpu/drm/panel/Kconfig                      |   9 +
 drivers/gpu/drm/panel/Makefile                     |   1 +
 drivers/gpu/drm/panel/panel-raydium-rm67191.c      | 670 +++++++++++++++++++++
 5 files changed, 727 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
 create mode 100644 drivers/gpu/drm/panel/panel-raydium-rm67191.c

Comments

Fabio Estevam June 26, 2019, 10:59 a.m. UTC | #1 
Hi Robert,

On Wed, Jun 26, 2019 at 7:21 AM Robert Chiras <robert.chiras@nxp.com> wrote:
>
> This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> protocol).
>
> Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Looks good to me:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks
Sam Ravnborg June 26, 2019, 11:33 a.m. UTC | #2 
Hi Robert.

On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote:
> This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> protocol).

I was about to apply these - but I get following warnings during build:
  CC      drivers/gpu/drm/panel/panel-raydium-rm67191.o
/home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c: In function ‘rad_bl_get_brightness’:
/home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c:470:17: warning: unused variable ‘dev’ [-Wunused-variable]
  struct device *dev = &dsi->dev;
                 ^~~
/home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c: In function ‘rad_bl_update_status’:
/home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c:492:17: warning: unused variable ‘dev’ [-Wunused-variable]
  struct device *dev = &dsi->dev;
                 ^~~

Please fix and update your scripts to catch this in the future.

	Sam
Robert Chiras June 26, 2019, 12:13 p.m. UTC | #3 
Hi Sam,

On Mi, 2019-06-26 at 13:33 +0200, Sam Ravnborg wrote:
> Hi Robert.
> 
> On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote:
> > 
> > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> > protocol).
> I was about to apply these - but I get following warnings during
> build:
>   CC      drivers/gpu/drm/panel/panel-raydium-rm67191.o
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c: In function ‘rad_bl_get_brightness’:
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c:470:17: warning: unused variable ‘dev’ [-Wunused-variable]
>   struct device *dev = &dsi->dev;
>                  ^~~
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c: In function ‘rad_bl_update_status’:
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c:492:17: warning: unused variable ‘dev’ [-Wunused-variable]
>   struct device *dev = &dsi->dev;
>                  ^~~
> 
> Please fix and update your scripts to catch this in the future.
Oh, I am sorry about that, seems that I missed that :(
Fixed and submitted.
> 
>         Sam

Thanks,
Robert