Message ID | 1561544420-15572-1-git-send-email-robert.chiras@nxp.com |
---|---|
Headers | show |
Series | Add DSI panel driver for Raydium RM67191 | expand |
Hi Robert, On Wed, Jun 26, 2019 at 7:21 AM Robert Chiras <robert.chiras@nxp.com> wrote: > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > protocol). > > Signed-off-by: Robert Chiras <robert.chiras@nxp.com> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Looks good to me: Reviewed-by: Fabio Estevam <festevam@gmail.com> Thanks
Hi Robert. On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote: > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > protocol). I was about to apply these - but I get following warnings during build: CC drivers/gpu/drm/panel/panel-raydium-rm67191.o /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c: In function ‘rad_bl_get_brightness’: /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c:470:17: warning: unused variable ‘dev’ [-Wunused-variable] struct device *dev = &dsi->dev; ^~~ /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c: In function ‘rad_bl_update_status’: /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-rm67191.c:492:17: warning: unused variable ‘dev’ [-Wunused-variable] struct device *dev = &dsi->dev; ^~~ Please fix and update your scripts to catch this in the future. Sam
Hi Sam, On Mi, 2019-06-26 at 13:33 +0200, Sam Ravnborg wrote: > Hi Robert. > > On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote: > > > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > > protocol). > I was about to apply these - but I get following warnings during > build: > CC drivers/gpu/drm/panel/panel-raydium-rm67191.o > /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium- > rm67191.c: In function ‘rad_bl_get_brightness’: > /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium- > rm67191.c:470:17: warning: unused variable ‘dev’ [-Wunused-variable] > struct device *dev = &dsi->dev; > ^~~ > /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium- > rm67191.c: In function ‘rad_bl_update_status’: > /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium- > rm67191.c:492:17: warning: unused variable ‘dev’ [-Wunused-variable] > struct device *dev = &dsi->dev; > ^~~ > > Please fix and update your scripts to catch this in the future. Oh, I am sorry about that, seems that I missed that :( Fixed and submitted. > > Sam Thanks, Robert