diff mbox series

[U-Boot,1/1] apalis_imx6: increase phy autoneg timeout

Message ID 20190621110024.16767-1-igor.opaniuk@gmail.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/1] apalis_imx6: increase phy autoneg timeout | expand

Commit Message

Igor Opaniuk June 21, 2019, 11 a.m. UTC 
From: Igor Opaniuk <igor.opaniuk@toradex.com>

Default value (4000ms) of PHY_ANEG_TIMEOUT for Micrel KSZ9031 contoller
isn't sufficient to finish auto-negotiation, which sometimes leads to
timeout errors:

Apalis iMX6 # dhcp
FEC Waiting for PHY auto negotiation to complete......... TIMEOUT !

Increase the auto-negotiation time-out to 8000ms.

Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---
 include/configs/apalis_imx6.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Schenker June 24, 2019, 7:44 a.m. UTC | #1 
On Fri, 2019-06-21 at 14:00 +0300, Igor Opaniuk wrote:
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> Default value (4000ms) of PHY_ANEG_TIMEOUT for Micrel KSZ9031 contoller
> isn't sufficient to finish auto-negotiation, which sometimes leads to
> timeout errors:
> 
> Apalis iMX6 # dhcp
> FEC Waiting for PHY auto negotiation to complete......... TIMEOUT !
> 
> Increase the auto-negotiation time-out to 8000ms.

Hi Igor, I did a lot of auto-negotiation tests with this PHY. It can happen,
that it has up to 12s for a connection with some partners. So I'd suggest to put
that timeout up to 15s to cover most situations.

Philippe

> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> ---
>  include/configs/apalis_imx6.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
> index 4b0a3fb26b..246d618442 100644
> --- a/include/configs/apalis_imx6.h
> +++ b/include/configs/apalis_imx6.h
> @@ -58,6 +58,7 @@
>  #define IMX_FEC_BASE			ENET_BASE_ADDR
>  #define CONFIG_FEC_XCV_TYPE		RGMII
>  #define CONFIG_ETHPRIME			"FEC"
> +#define PHY_ANEG_TIMEOUT		8000 /* PHY needs longer aneg time */
>  #define CONFIG_FEC_MXC_PHYADDR		6
>  #define CONFIG_TFTP_TSIZE
>
Oleksandr Suvorov June 25, 2019, 7:01 a.m. UTC | #2 
> From: U-Boot <u-boot-bounces@lists.denx.de> on behalf of Igor Opaniuk <igor.opaniuk@gmail.com>
> Sent: Friday, June 21, 2019 14:00
> To: u-boot@lists.denx.de
> Cc: Marcel Ziswiler; Max Krummenacher
> Subject: [U-Boot] [PATCH 1/1] apalis_imx6: increase phy autoneg timeout
> 
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> Default value (4000ms) of PHY_ANEG_TIMEOUT for Micrel KSZ9031 contoller
> isn't sufficient to finish auto-negotiation, which sometimes leads to
> timeout errors:
> 
> Apalis iMX6 # dhcp
> FEC Waiting for PHY auto negotiation to complete......... TIMEOUT !
>
> Increase the auto-negotiation time-out to 8000ms.
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>  include/configs/apalis_imx6.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
> index 4b0a3fb26b..246d618442 100644
> --- a/include/configs/apalis_imx6.h
> +++ b/include/configs/apalis_imx6.h
>  @@ -58,6 +58,7 @@
>  #define IMX_FEC_BASE                   ENET_BASE_ADDR
>  #define CONFIG_FEC_XCV_TYPE            RGMII
>  #define CONFIG_ETHPRIME                        "FEC"
> +#define PHY_ANEG_TIMEOUT               8000 /* PHY needs longer aneg time */
> #define CONFIG_FEC_MXC_PHYADDR         6
> #define CONFIG_TFTP_TSIZE
diff mbox series

Patch

diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
index 4b0a3fb26b..246d618442 100644
--- a/include/configs/apalis_imx6.h
+++ b/include/configs/apalis_imx6.h
@@ -58,6 +58,7 @@ 
 #define IMX_FEC_BASE			ENET_BASE_ADDR
 #define CONFIG_FEC_XCV_TYPE		RGMII
 #define CONFIG_ETHPRIME			"FEC"
+#define PHY_ANEG_TIMEOUT		8000 /* PHY needs longer aneg time */
 #define CONFIG_FEC_MXC_PHYADDR		6
 #define CONFIG_TFTP_TSIZE