mbox series

[U-Boot,v4,0/4] add command env erase

Message ID 20190428085128.8479-1-frank-w@public-files.de
Headers show
Series add command env erase | expand

Message

Frank Wunderlich April 28, 2019, 8:51 a.m. UTC
sometimes it is needed to erase the non-volatile environment
e.g. for boot-up with builtin-environment or after resizing env

this series add basic functionality for erasing environment from storage
as a first storage-driver mmc is introduced, other needs to be added later

changes since v3:
 - fixes
 - Kconfig-option as suggested by Simon Goldschmidt
 - including CONFIG_ENV_OFFSET_REDUND (4/4 is RFC)

Frank Wunderlich (4):
  env: register erase command
  env: mmc: add erase-function
  env: add option to use redundant offset
  [RFC] env: call env_erase twice if CONFIG_ENV_OFFSET_REDUND is set

 cmd/Kconfig           |  8 ++++++++
 cmd/nvedit.c          | 26 ++++++++++++++++++++++++++
 env/env.c             | 30 ++++++++++++++++++++++++++++++
 env/mmc.c             | 36 ++++++++++++++++++++++++++++++++++++
 include/environment.h | 17 +++++++++++++++++
 5 files changed, 117 insertions(+)

--
2.17.1

Comments

Frank Wunderlich May 20, 2019, 6:34 p.m. UTC | #1
Hi,

Just a friendly reminder.

Any comments on my patches?

Regards Frank

Am 28. April 2019 10:51:24 MESZ schrieb Frank Wunderlich <frank-w@public-files.de>:
>sometimes it is needed to erase the non-volatile environment
>e.g. for boot-up with builtin-environment or after resizing env
>
>this series add basic functionality for erasing environment from
>storage
>as a first storage-driver mmc is introduced, other needs to be added
>later
>
>changes since v3:
> - fixes
> - Kconfig-option as suggested by Simon Goldschmidt
> - including CONFIG_ENV_OFFSET_REDUND (4/4 is RFC)
>
>Frank Wunderlich (4):
>  env: register erase command
>  env: mmc: add erase-function
>  env: add option to use redundant offset
>  [RFC] env: call env_erase twice if CONFIG_ENV_OFFSET_REDUND is set
>
> cmd/Kconfig           |  8 ++++++++
> cmd/nvedit.c          | 26 ++++++++++++++++++++++++++
> env/env.c             | 30 ++++++++++++++++++++++++++++++
> env/mmc.c             | 36 ++++++++++++++++++++++++++++++++++++
> include/environment.h | 17 +++++++++++++++++
> 5 files changed, 117 insertions(+)
>
>--
>2.17.1
Frank Wunderlich June 24, 2019, 10:30 a.m. UTC | #2
no opinion about the last version?

regards Frank

> Am 28. April 2019 10:51:24 MESZ schrieb Frank Wunderlich <frank-w@public-files.de>:
> >sometimes it is needed to erase the non-volatile environment
> >e.g. for boot-up with builtin-environment or after resizing env
> >
> >this series add basic functionality for erasing environment from
> >storage
> >as a first storage-driver mmc is introduced, other needs to be added
> >later
> >
> >changes since v3:
> > - fixes
> > - Kconfig-option as suggested by Simon Goldschmidt
> > - including CONFIG_ENV_OFFSET_REDUND (4/4 is RFC)
> >
> >Frank Wunderlich (4):
> >  env: register erase command
> >  env: mmc: add erase-function
> >  env: add option to use redundant offset
> >  [RFC] env: call env_erase twice if CONFIG_ENV_OFFSET_REDUND is set
> >
> > cmd/Kconfig           |  8 ++++++++
> > cmd/nvedit.c          | 26 ++++++++++++++++++++++++++
> > env/env.c             | 30 ++++++++++++++++++++++++++++++
> > env/mmc.c             | 36 ++++++++++++++++++++++++++++++++++++
> > include/environment.h | 17 +++++++++++++++++
> > 5 files changed, 117 insertions(+)
> >
> >--
> >2.17.1
>
Tom Rini June 24, 2019, 6:16 p.m. UTC | #3
On Mon, Jun 24, 2019 at 12:30:01PM +0200, Frank Wunderlich wrote:
> no opinion about the last version?
> 
> regards Frank
> 
> > Am 28. April 2019 10:51:24 MESZ schrieb Frank Wunderlich <frank-w@public-files.de>:
> > >sometimes it is needed to erase the non-volatile environment
> > >e.g. for boot-up with builtin-environment or after resizing env
> > >
> > >this series add basic functionality for erasing environment from
> > >storage
> > >as a first storage-driver mmc is introduced, other needs to be added
> > >later
> > >
> > >changes since v3:
> > > - fixes
> > > - Kconfig-option as suggested by Simon Goldschmidt
> > > - including CONFIG_ENV_OFFSET_REDUND (4/4 is RFC)
> > >
> > >Frank Wunderlich (4):
> > >  env: register erase command
> > >  env: mmc: add erase-function
> > >  env: add option to use redundant offset
> > >  [RFC] env: call env_erase twice if CONFIG_ENV_OFFSET_REDUND is set
> > >
> > > cmd/Kconfig           |  8 ++++++++
> > > cmd/nvedit.c          | 26 ++++++++++++++++++++++++++
> > > env/env.c             | 30 ++++++++++++++++++++++++++++++
> > > env/mmc.c             | 36 ++++++++++++++++++++++++++++++++++++
> > > include/environment.h | 17 +++++++++++++++++
> > > 5 files changed, 117 insertions(+)

Seems like a reasonable concept and I believe I looked it over and
everything new is under a CONFIG guard, so, thanks!
Simon Goldschmidt June 24, 2019, 7:25 p.m. UTC | #4
Hi Frank,

Am 24.06.2019 um 12:30 schrieb Frank Wunderlich:
> no opinion about the last version?

Sorry, I tried multiple times to review this but failed to find the 
time. Seems like I found the time now ;-)

I'll reply to the original patch mails.

Regards,
Simon

> 
> regards Frank
> 
>> Am 28. April 2019 10:51:24 MESZ schrieb Frank Wunderlich <frank-w@public-files.de>:
>>> sometimes it is needed to erase the non-volatile environment
>>> e.g. for boot-up with builtin-environment or after resizing env
>>>
>>> this series add basic functionality for erasing environment from
>>> storage
>>> as a first storage-driver mmc is introduced, other needs to be added
>>> later
>>>
>>> changes since v3:
>>> - fixes
>>> - Kconfig-option as suggested by Simon Goldschmidt
>>> - including CONFIG_ENV_OFFSET_REDUND (4/4 is RFC)
>>>
>>> Frank Wunderlich (4):
>>>   env: register erase command
>>>   env: mmc: add erase-function
>>>   env: add option to use redundant offset
>>>   [RFC] env: call env_erase twice if CONFIG_ENV_OFFSET_REDUND is set
>>>
>>> cmd/Kconfig           |  8 ++++++++
>>> cmd/nvedit.c          | 26 ++++++++++++++++++++++++++
>>> env/env.c             | 30 ++++++++++++++++++++++++++++++
>>> env/mmc.c             | 36 ++++++++++++++++++++++++++++++++++++
>>> include/environment.h | 17 +++++++++++++++++
>>> 5 files changed, 117 insertions(+)
>>>
>>> --
>>> 2.17.1
>>